6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-06-27 14:24:40 +00:00
Code Issues Projects Releases Wiki Activity

Verifier: Check for null operands in !llvm.module.flags

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@228818 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
David Majnemer
2015-02-11 09:13:06 +00:00
parent 0686b8affc
commit f937622ece
3 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/IR/Module.cpp
View File

@ -278,7 +278,7 @@ void Module::eraseNamedMetadata(NamedMDNode *NMD) {
} }
bool Module::isValidModFlagBehavior(Metadata *MD, ModFlagBehavior &MFB) { bool Module::isValidModFlagBehavior(Metadata *MD, ModFlagBehavior &MFB) {
if (ConstantInt *Behavior = mdconst::dyn_extract<ConstantInt>(MD)) { if (ConstantInt *Behavior = mdconst::dyn_extract_or_null<ConstantInt>(MD)) {
uint64_t Val = Behavior->getLimitedValue(); uint64_t Val = Behavior->getLimitedValue();
if (Val >= ModFlagBehaviorFirstVal && Val <= ModFlagBehaviorLastVal) { if (Val >= ModFlagBehaviorFirstVal && Val <= ModFlagBehaviorLastVal) {
MFB = static_cast<ModFlagBehavior>(Val); MFB = static_cast<ModFlagBehavior>(Val);
@ -298,7 +298,7 @@ getModuleFlagsMetadata(SmallVectorImpl<ModuleFlagEntry> &Flags) const {
ModFlagBehavior MFB; ModFlagBehavior MFB;
if (Flag->getNumOperands() >= 3 && if (Flag->getNumOperands() >= 3 &&
isValidModFlagBehavior(Flag->getOperand(0), MFB) && isValidModFlagBehavior(Flag->getOperand(0), MFB) &&
isa<MDString>(Flag->getOperand(1))) { dyn_cast_or_null<MDString>(Flag->getOperand(1))) {
// Check the operands of the MDNode before accessing the operands. // Check the operands of the MDNode before accessing the operands.
// The verifier will actually catch these failures. // The verifier will actually catch these failures.
MDString *Key = cast<MDString>(Flag->getOperand(1)); MDString *Key = cast<MDString>(Flag->getOperand(1));

2
lib/IR/Verifier.cpp
View File

@ -869,7 +869,7 @@ Verifier::visitModuleFlag(const MDNode *Op,
Module::ModFlagBehavior MFB; Module::ModFlagBehavior MFB;
if (!Module::isValidModFlagBehavior(Op->getOperand(0), MFB)) { if (!Module::isValidModFlagBehavior(Op->getOperand(0), MFB)) {
Assert1( Assert1(
mdconst::dyn_extract<ConstantInt>(Op->getOperand(0)), mdconst::dyn_extract_or_null<ConstantInt>(Op->getOperand(0)),
"invalid behavior operand in module flag (expected constant integer)", "invalid behavior operand in module flag (expected constant integer)",
Op->getOperand(0)); Op->getOperand(0));
Assert1(false, Assert1(false,

6
test/Verifier/module-flags-2.ll Normal file
View File

@ -0,0 +1,6 @@
; RUN: not llvm-as < %s -o /dev/null 2>&1 | FileCheck %s
!llvm.module.flags = !{!0}
!0 = !{null, null, null}
; CHECK: invalid behavior operand in module flag (expected constant integer)