From fa1be5d99153a4709740ce5aabba3793e9f77982 Mon Sep 17 00:00:00 2001 From: Evan Cheng Date: Tue, 29 Sep 2009 07:07:30 +0000 Subject: [PATCH] Fix PR4687. Pre ARMv5te does not support ldrd / strd. Patch by John Tytgat. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@83058 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/ARM/ARMLoadStoreOptimizer.cpp | 4 ++++ test/CodeGen/ARM/2009-09-28-LdStOptiBug.ll | 19 +++++++++++++++++++ 2 files changed, 23 insertions(+) create mode 100644 test/CodeGen/ARM/2009-09-28-LdStOptiBug.ll diff --git a/lib/Target/ARM/ARMLoadStoreOptimizer.cpp b/lib/Target/ARM/ARMLoadStoreOptimizer.cpp index f1a6c642b86..031f5b0da4c 100644 --- a/lib/Target/ARM/ARMLoadStoreOptimizer.cpp +++ b/lib/Target/ARM/ARMLoadStoreOptimizer.cpp @@ -1191,6 +1191,10 @@ ARMPreAllocLoadStoreOpt::CanFormLdStDWord(MachineInstr *Op0, MachineInstr *Op1, unsigned &PredReg, ARMCC::CondCodes &Pred, bool &isT2) { + // Make sure we're allowed to generate LDRD/STRD. + if (!STI->hasV5TEOps()) + return false; + // FIXME: FLDS / FSTS -> FLDD / FSTD unsigned Scale = 1; unsigned Opcode = Op0->getOpcode(); diff --git a/test/CodeGen/ARM/2009-09-28-LdStOptiBug.ll b/test/CodeGen/ARM/2009-09-28-LdStOptiBug.ll new file mode 100644 index 00000000000..53bd6682595 --- /dev/null +++ b/test/CodeGen/ARM/2009-09-28-LdStOptiBug.ll @@ -0,0 +1,19 @@ +; RUN: llc < %s -mtriple=armv5-unknown-linux-gnueabi -mcpu=arm10tdmi | FileCheck %s +; PR4687 + +%0 = type { double, double } + +define arm_aapcscc void @foo(%0* noalias nocapture sret %agg.result, double %x.0, double %y.0) nounwind { +; CHECK: foo: +; CHECK: bl __adddf3 +; CHECK-NOT: strd +; CHECK: mov + %x76 = fmul double %y.0, 0.000000e+00 ; [#uses=1] + %x77 = fadd double %y.0, 0.000000e+00 ; [#uses=1] + %tmpr = fadd double %x.0, %x76 ; [#uses=1] + %agg.result.0 = getelementptr %0* %agg.result, i32 0, i32 0 ; [#uses=1] + store double %tmpr, double* %agg.result.0, align 8 + %agg.result.1 = getelementptr %0* %agg.result, i32 0, i32 1 ; [#uses=1] + store double %x77, double* %agg.result.1, align 8 + ret void +}