From fd04561e1b21f41b3c03cae4481f1d45f699c6de Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Thu, 28 Aug 2003 19:56:10 +0000 Subject: [PATCH] Fix really nasty bugs in the CWriter, handling invoke instructions. Tracking these down was NOT phun. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@8181 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/CBackend/CBackend.cpp | 7 +++++-- lib/Target/CBackend/Writer.cpp | 7 +++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/lib/Target/CBackend/CBackend.cpp b/lib/Target/CBackend/CBackend.cpp index a6220751415..721ead091c2 100644 --- a/lib/Target/CBackend/CBackend.cpp +++ b/lib/Target/CBackend/CBackend.cpp @@ -894,7 +894,8 @@ void CWriter::printFunction(Function *F) { UI != UE; ++UI) if (TerminatorInst *TI = dyn_cast(*UI)) if (TI != Prev->getTerminator() || - isa(Prev->getTerminator())) { + isa(Prev->getTerminator()) || + isa(Prev->getTerminator())) { NeedsLabel = true; break; } @@ -968,6 +969,8 @@ void CWriter::visitInvokeInst(InvokeInst &II) { Out << " }\n" << " __llvm_jmpbuf_list = &Entry;\n" << " "; + + if (II.getType() != Type::VoidTy) outputLValue(&II); visitCallSite(&II); Out << ";\n" << " __llvm_jmpbuf_list = Entry.next;\n" @@ -998,7 +1001,7 @@ void CWriter::printBranchToBlock(BasicBlock *CurBB, BasicBlock *Succ, Out << "; /* for PHI node */\n"; } - if (CurBB->getNext() != Succ) { + if (CurBB->getNext() != Succ || isa(CurBB->getTerminator())) { Out << std::string(Indent, ' ') << " goto "; writeOperand(Succ); Out << ";\n"; diff --git a/lib/Target/CBackend/Writer.cpp b/lib/Target/CBackend/Writer.cpp index a6220751415..721ead091c2 100644 --- a/lib/Target/CBackend/Writer.cpp +++ b/lib/Target/CBackend/Writer.cpp @@ -894,7 +894,8 @@ void CWriter::printFunction(Function *F) { UI != UE; ++UI) if (TerminatorInst *TI = dyn_cast(*UI)) if (TI != Prev->getTerminator() || - isa(Prev->getTerminator())) { + isa(Prev->getTerminator()) || + isa(Prev->getTerminator())) { NeedsLabel = true; break; } @@ -968,6 +969,8 @@ void CWriter::visitInvokeInst(InvokeInst &II) { Out << " }\n" << " __llvm_jmpbuf_list = &Entry;\n" << " "; + + if (II.getType() != Type::VoidTy) outputLValue(&II); visitCallSite(&II); Out << ";\n" << " __llvm_jmpbuf_list = Entry.next;\n" @@ -998,7 +1001,7 @@ void CWriter::printBranchToBlock(BasicBlock *CurBB, BasicBlock *Succ, Out << "; /* for PHI node */\n"; } - if (CurBB->getNext() != Succ) { + if (CurBB->getNext() != Succ || isa(CurBB->getTerminator())) { Out << std::string(Indent, ' ') << " goto "; writeOperand(Succ); Out << ";\n";