From fff03c9074ba5ee883b67d422c581f2397779264 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Sun, 19 Sep 2004 19:01:06 +0000 Subject: [PATCH] Fix a nasty iterator invalidation problem I introduced yesterday. This unfortunately is the cause of a bunch of failures from tonight, and the reason the tester is running so slow :( git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@16407 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Analysis/IPA/CallGraph.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/Analysis/IPA/CallGraph.cpp b/lib/Analysis/IPA/CallGraph.cpp index e3a60248895..dbf5b9f95bd 100644 --- a/lib/Analysis/IPA/CallGraph.cpp +++ b/lib/Analysis/IPA/CallGraph.cpp @@ -211,10 +211,10 @@ void CallGraphNode::removeCallEdgeTo(CallGraphNode *Callee) { // the specified callee function. This takes more time to execute than // removeCallEdgeTo, so it should not be used unless necessary. void CallGraphNode::removeAnyCallEdgeTo(CallGraphNode *Callee) { - for (std::vector::iterator I = CalledFunctions.begin(), - E = CalledFunctions.end(); I != E; ++I) - if (*I == Callee) { - CalledFunctions.erase(I); - E = CalledFunctions.end(); + for (unsigned i = 0, e = CalledFunctions.size(); i != e; ++i) + if (CalledFunctions[i] == Callee) { + CalledFunctions[i] = CalledFunctions.back(); + CalledFunctions.pop_back(); + --i; --e; } }