mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2025-07-24 06:25:18 +00:00
198d8baafb
One of several parallel first steps to remove the target type of pointers,
replacing them with a single opaque pointer type.
This adds an explicit type parameter to the gep instruction so that when the
first parameter becomes an opaque pointer type, the type to gep through is
still available to the instructions.
* This doesn't modify gep operators, only instructions (operators will be
handled separately)
* Textual IR changes only. Bitcode (including upgrade) and changing the
in-memory representation will be in separate changes.
* geps of vectors are transformed as:
getelementptr <4 x float*> %x, ...
->getelementptr float, <4 x float*> %x, ...
Then, once the opaque pointer type is introduced, this will ultimately look
like:
getelementptr float, <4 x ptr> %x
with the unambiguous interpretation that it is a vector of pointers to float.
* address spaces remain on the pointer, not the type:
getelementptr float addrspace(1)* %x
->getelementptr float, float addrspace(1)* %x
Then, eventually:
getelementptr float, ptr addrspace(1) %x
Importantly, the massive amount of test case churn has been automated by
same crappy python code. I had to manually update a few test cases that
wouldn't fit the script's model (r228970,r229196,r229197,r229198). The
python script just massages stdin and writes the result to stdout, I
then wrapped that in a shell script to handle replacing files, then
using the usual find+xargs to migrate all the files.
update.py:
import fileinput
import sys
import re
ibrep = re.compile(r"(^.*?[^%\w]getelementptr inbounds )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
normrep = re.compile( r"(^.*?[^%\w]getelementptr )(((?:<\d* x )?)(.*?)(| addrspace\(\d\)) *\*(|>)(?:$| *(?:%|@|null|undef|blockaddress|getelementptr|addrspacecast|bitcast|inttoptr|\[\[[a-zA-Z]|\{\{).*$))")
def conv(match, line):
if not match:
return line
line = match.groups()[0]
if len(match.groups()[5]) == 0:
line += match.groups()[2]
line += match.groups()[3]
line += ", "
line += match.groups()[1]
line += "\n"
return line
for line in sys.stdin:
if line.find("getelementptr ") == line.find("getelementptr inbounds"):
if line.find("getelementptr inbounds") != line.find("getelementptr inbounds ("):
line = conv(re.match(ibrep, line), line)
elif line.find("getelementptr ") != line.find("getelementptr ("):
line = conv(re.match(normrep, line), line)
sys.stdout.write(line)
apply.sh:
for name in "$@"
do
python3 `dirname "$0"`/update.py < "$name" > "$name.tmp" && mv "$name.tmp" "$name"
rm -f "$name.tmp"
done
The actual commands:
From llvm/src:
find test/ -name *.ll | xargs ./apply.sh
From llvm/src/tools/clang:
find test/ -name *.mm -o -name *.m -o -name *.cpp -o -name *.c | xargs -I '{}' ../../apply.sh "{}"
From llvm/src/tools/polly:
find test/ -name *.ll | xargs ./apply.sh
After that, check-all (with llvm, clang, clang-tools-extra, lld,
compiler-rt, and polly all checked out).
The extra 'rm' in the apply.sh script is due to a few files in clang's test
suite using interesting unicode stuff that my python script was throwing
exceptions on. None of those files needed to be migrated, so it seemed
sufficient to ignore those cases.
Reviewers: rafael, dexonsmith, grosser
Differential Revision: http://reviews.llvm.org/D7636
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@230786 91177308-0d34-0410-b5e6-96231b3b80d8
144 lines
2.9 KiB
LLVM
144 lines
2.9 KiB
LLVM
; RUN: opt < %s -basicaa -sink -S | FileCheck %s
|
|
|
|
@A = external global i32
|
|
@B = external global i32
|
|
|
|
; Sink should sink the load past the store (which doesn't overlap) into
|
|
; the block that uses it.
|
|
|
|
; CHECK-LABEL: @foo(
|
|
; CHECK: true:
|
|
; CHECK-NEXT: %l = load i32* @A
|
|
; CHECK-NEXT: ret i32 %l
|
|
|
|
define i32 @foo(i1 %z) {
|
|
%l = load i32* @A
|
|
store i32 0, i32* @B
|
|
br i1 %z, label %true, label %false
|
|
true:
|
|
ret i32 %l
|
|
false:
|
|
ret i32 0
|
|
}
|
|
|
|
; But don't sink load volatiles...
|
|
|
|
; CHECK-LABEL: @foo2(
|
|
; CHECK: load volatile
|
|
; CHECK-NEXT: store i32
|
|
|
|
define i32 @foo2(i1 %z) {
|
|
%l = load volatile i32* @A
|
|
store i32 0, i32* @B
|
|
br i1 %z, label %true, label %false
|
|
true:
|
|
ret i32 %l
|
|
false:
|
|
ret i32 0
|
|
}
|
|
|
|
; Sink to the nearest post-dominator
|
|
|
|
; CHECK-LABEL: @diamond(
|
|
; CHECK: X:
|
|
; CHECK-NEXT: phi
|
|
; CHECK-NEXT: mul nsw
|
|
; CHECK-NEXT: sub
|
|
|
|
define i32 @diamond(i32 %a, i32 %b, i32 %c) {
|
|
%1 = mul nsw i32 %c, %b
|
|
%2 = icmp sgt i32 %a, 0
|
|
br i1 %2, label %B0, label %B1
|
|
|
|
B0: ; preds = %0
|
|
br label %X
|
|
|
|
B1: ; preds = %0
|
|
br label %X
|
|
|
|
X: ; preds = %5, %3
|
|
%.01 = phi i32 [ %c, %B0 ], [ %a, %B1 ]
|
|
%R = sub i32 %1, %.01
|
|
ret i32 %R
|
|
}
|
|
|
|
; We shouldn't sink constant sized allocas from the entry block, since CodeGen
|
|
; interprets allocas outside the entry block as dynamically sized stack objects.
|
|
|
|
; CHECK-LABEL: @alloca_nosink
|
|
; CHECK: entry:
|
|
; CHECK-NEXT: alloca
|
|
define i32 @alloca_nosink(i32 %a, i32 %b) {
|
|
entry:
|
|
%0 = alloca i32
|
|
%1 = icmp ne i32 %a, 0
|
|
br i1 %1, label %if, label %endif
|
|
|
|
if:
|
|
%2 = getelementptr i32, i32* %0, i32 1
|
|
store i32 0, i32* %0
|
|
store i32 1, i32* %2
|
|
%3 = getelementptr i32, i32* %0, i32 %b
|
|
%4 = load i32* %3
|
|
ret i32 %4
|
|
|
|
endif:
|
|
ret i32 0
|
|
}
|
|
|
|
; Make sure we sink dynamic sized allocas
|
|
|
|
; CHECK-LABEL: @alloca_sink_dynamic
|
|
; CHECK: entry:
|
|
; CHECK-NOT: alloca
|
|
; CHECK: if:
|
|
; CHECK-NEXT: alloca
|
|
define i32 @alloca_sink_dynamic(i32 %a, i32 %b, i32 %size) {
|
|
entry:
|
|
%0 = alloca i32, i32 %size
|
|
%1 = icmp ne i32 %a, 0
|
|
br i1 %1, label %if, label %endif
|
|
|
|
if:
|
|
%2 = getelementptr i32, i32* %0, i32 1
|
|
store i32 0, i32* %0
|
|
store i32 1, i32* %2
|
|
%3 = getelementptr i32, i32* %0, i32 %b
|
|
%4 = load i32* %3
|
|
ret i32 %4
|
|
|
|
endif:
|
|
ret i32 0
|
|
}
|
|
|
|
; We also want to sink allocas that are not in the entry block. These
|
|
; will already be considered as dynamically sized stack objects, so sinking
|
|
; them does no further damage.
|
|
|
|
; CHECK-LABEL: @alloca_sink_nonentry
|
|
; CHECK: if0:
|
|
; CHECK-NOT: alloca
|
|
; CHECK: if:
|
|
; CHECK-NEXT: alloca
|
|
define i32 @alloca_sink_nonentry(i32 %a, i32 %b, i32 %c) {
|
|
entry:
|
|
%cmp = icmp ne i32 %c, 0
|
|
br i1 %cmp, label %endif, label %if0
|
|
|
|
if0:
|
|
%0 = alloca i32
|
|
%1 = icmp ne i32 %a, 0
|
|
br i1 %1, label %if, label %endif
|
|
|
|
if:
|
|
%2 = getelementptr i32, i32* %0, i32 1
|
|
store i32 0, i32* %0
|
|
store i32 1, i32* %2
|
|
%3 = getelementptr i32, i32* %0, i32 %b
|
|
%4 = load i32* %3
|
|
ret i32 %4
|
|
|
|
endif:
|
|
ret i32 0
|
|
}
|