mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2025-07-16 11:24:39 +00:00
3f8a26f6fe
This class is generally useful. In breaking it out, the primary change is that it has been made non-virtual. It seems like being abstract led to there being 3 different (2 in llvm + 1 in clang) concrete implementations which disagreed about the ownership of the saved strings (see the manual call to free() in the unittest StrDupSaver; yes this is different from the CommandLine.cpp StrDupSaver which owns the stored strings; which is different from Clang's StringSetSaver which just holds a reference to a std::set<std::string> which owns the strings). I've identified 2 other places in the codebase that are open-coding this pattern: memcpy(Alloc.Allocate<char>(strlen(S)+1), S, strlen(S)+1) I'll be switching them over. They are * llvm::sys::Process::GetArgumentVector * The StringAllocator member of YAMLIO's Input class This also will allow simplifying Clang's driver.cpp quite a bit. Let me know if there are any other places that could benefit from StringSaver. I'm also thinking of adding a saveStringRef member for getting a stable StringRef. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@215784 91177308-0d34-0410-b5e6-96231b3b80d8
34 lines
837 B
C++
34 lines
837 B
C++
//===- llvm/Support/StringSaver.h - Stable storage for strings --*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLVM_SUPPORT_STRINGSAVER_H
|
|
#define LLVM_SUPPORT_STRINGSAVER_H
|
|
|
|
#include "llvm/Support/Allocator.h"
|
|
#include <cstring>
|
|
|
|
namespace llvm {
|
|
|
|
/// \brief Saves strings in stable storage that it owns.
|
|
class StringSaver {
|
|
BumpPtrAllocator Alloc;
|
|
|
|
public:
|
|
const char *saveCStr(const char *CStr) {
|
|
auto Len = std::strlen(CStr) + 1; // Don't forget the NUL!
|
|
char *Buf = Alloc.Allocate<char>(Len);
|
|
std::memcpy(Buf, CStr, Len);
|
|
return Buf;
|
|
}
|
|
};
|
|
|
|
} // end namespace llvm
|
|
|
|
#endif
|