Chandler Carruth 69774fa1c4 [LPM] A targeted but somewhat horrible fix to the legacy pass manager's ... querying of the pass registry. The pass manager relies on the static registry of PassInfo objects to perform all manner of its functionality. I don't understand why it does much of this. My very vague understanding is that this registry is touched both during static initialization *and* while each pass is being constructed. As a consequence it is hard to make accessing it not require a acquiring some lock. This lock ends up in the hot path of setting up, tearing down, and invaliditing analyses in the legacy pass manager. On most systems you can observe this as a non-trivial % of the time spent in 'ninja check-llvm'. However, I haven't really seen it be more than 1% in extreme cases of compiling more real-world software, including LTO. Unfortunately, some of the GPU JITs are seeing this taking essentially all of their time because they have very small IR running through a small pass pipeline very many times (at least, this is the vague understanding I have of it). This patch tries to minimize the cost of looking up PassInfo objects by leveraging the fact that the objects themselves are immutable and they are allocated separately on the heap and so don't have their address change. It also requires a change I made the last time I tried to debug this problem which removed the ability to de-register a pass from the registry. This patch creates a single access path to these objects inside the PMTopLevelManager which memoizes the result of querying the registry. This is somewhat gross as I don't really know if PMTopLevelManager is the *right* place to put it, and I dislike using a mutable member to memoize things, but it seems to work. For long-lived pass managers this should completely eliminate the cost of acquiring locks to look into the pass registry once the memoized cache is warm. For 'ninja check' I measured about 1.5% reduction in CPU time and in total time on a machine with 32 hardware threads. For normal compilation, I don't know how much this will help, sadly. We will still pay the cost while we populate the memoized cache. I don't think it will hurt though, and for LTO or compiles with many small functions it should still be a win. However, for tight loops around a pass manager with many passes and small modules, this will help tremendously. On the AArch64 backend I saw nearly 50% reductions in time to complete 2000 cycles of spinning up and tearing down the pipeline. Measurements from Owen of an actual long-lived pass manager show more along the lines of 10% improvements. Differential Revision: http://reviews.llvm.org/D7213 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@227299 91177308-0d34-0410-b5e6-96231b3b80d8		2015-01-28 09:47:21 +00:00
..
AsmWriter.cpp	IR: DwarfNode => DebugNode, NFC	2015-01-22 22:47:44 +00:00
AsmWriter.h
AttributeImpl.h
Attributes.cpp
AutoUpgrade.cpp	[X86] Use i8 immediate for comparison type on AVX512 packed integer instructions. This matches floating point equivalents. Includes autoupgrade support to convert old code.	2015-01-25 23:26:02 +00:00
BasicBlock.cpp
CMakeLists.txt	Revert GCStrategy ownership changes	2015-01-26 18:26:35 +00:00
Comdat.cpp
ConstantFold.cpp
ConstantFold.h
ConstantRange.cpp
Constants.cpp
ConstantsContext.h
Core.cpp
DataLayout.cpp
DebugInfo.cpp	DebugInfo: Fix use after return found by asan.	2015-01-24 19:55:23 +00:00
DebugLoc.cpp
DiagnosticInfo.cpp
DiagnosticPrinter.cpp
DIBuilder.cpp
Dominators.cpp
Function.cpp	Revert GCStrategy ownership changes	2015-01-26 18:26:35 +00:00
GCOV.cpp	llvm-cov: Don't use llvm::outs() in library code	2015-01-23 23:09:27 +00:00
Globals.cpp
GVMaterializer.cpp
InlineAsm.cpp
Instruction.cpp
Instructions.cpp
IntrinsicInst.cpp
IRBuilder.cpp	Intrinsics: introduce llvm_any_ty aka ValueType Any	2015-01-22 20:14:38 +00:00
IRPrintingPasses.cpp
LegacyPassManager.cpp	[LPM] A targeted but somewhat horrible fix to the legacy pass manager's	2015-01-28 09:47:21 +00:00
LLVMBuild.txt
LLVMContext.cpp
LLVMContextImpl.cpp	Revert GCStrategy ownership changes	2015-01-26 18:26:35 +00:00
LLVMContextImpl.h	Revert GCStrategy ownership changes	2015-01-26 18:26:35 +00:00
Makefile
Mangler.cpp
MDBuilder.cpp
Metadata.cpp	IR: Change GenericDwarfNode::getHeader() to StringRef	2015-01-22 23:10:55 +00:00
MetadataTracking.cpp
Module.cpp
module.modulemap
Pass.cpp	Refactoring cl::parser construction and initialization.	2015-01-22 21:01:12 +00:00
PassManager.cpp
PassRegistry.cpp
Statepoint.cpp	Intrinsics: introduce llvm_any_ty aka ValueType Any	2015-01-22 20:14:38 +00:00
SymbolTableListTraitsImpl.h
Type.cpp
TypeFinder.cpp
Use.cpp
UseListOrder.cpp
User.cpp
Value.cpp
ValueSymbolTable.cpp
ValueTypes.cpp
Verifier.cpp	Intrinsics: introduce llvm_any_ty aka ValueType Any	2015-01-22 20:14:38 +00:00