mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-12-26 21:32:10 +00:00
d89b0f200c
optimize a call to a llvm intrinsic to something that invovles a call to a C
library call, make sure it sets the right calling convention on the call.
e.g.
extern double pow(double, double);
double t(double x) {
return pow(10, x);
}
Compiles to something like this for AAPCS-VFP:
define arm_aapcs_vfpcc double @t(double %x) #0 {
entry:
%0 = call double @llvm.pow.f64(double 1.000000e+01, double %x)
ret double %0
}
declare double @llvm.pow.f64(double, double) #1
Simplify libcall (part of instcombine) will turn the above into:
define arm_aapcs_vfpcc double @t(double %x) #0 {
entry:
%__exp10 = call double @__exp10(double %x) #1
ret double %__exp10
}
declare double @__exp10(double)
The pre-instcombine code works because calls to LLVM builtins are special.
Instruction selection will chose the right calling convention for the call.
However, the code after instcombine is wrong. The call to __exp10 will use
the C calling convention.
I can think of 3 options to fix this.
1. Make "C" calling convention just work since the target should know what CC
is being used.
This doesn't work because each function can use different CC with the "pcs"
attribute.
2. Have Clang add the right CC keyword on the calls to LLVM builtin.
This will work but it doesn't match the LLVM IR specification which states
these are "Standard C Library Intrinsics".
3. Fix simplify libcall so the resulting calls to the C routines will have the
proper CC keyword. e.g.
%__exp10 = call arm_aapcs_vfpcc double @__exp10(double %x) #1
This works and is the solution I implemented here.
Both solutions #2 and #3 would work. After carefully considering the pros and
cons, I decided to implement #3 for the following reasons.
1. It doesn't change the "spec" of the intrinsics.
2. It's a self-contained fix.
There are a couple of potential downsides.
1. There could be other places in the optimizer that is broken in the same way
that's not addressed by this.
2. There could be other calling conventions that need to be propagated by
simplify-libcall that's not handled.
But for now, this is the fix that I'm most comfortable with.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203488 91177308-0d34-0410-b5e6-96231b3b80d8
24 lines
690 B
LLVM
24 lines
690 B
LLVM
; RUN: opt -S < %s -instcombine | FileCheck %s
|
|
|
|
; When simplify-libcall change an intrinsic call to a call to a library
|
|
; routine, it needs to set the proper calling convention for callers
|
|
; which use ARM target specific calling conventions.
|
|
; rdar://16261856
|
|
|
|
target triple = "thumbv7-apple-ios7"
|
|
|
|
; Function Attrs: nounwind ssp
|
|
define arm_aapcs_vfpcc double @t(double %x) #0 {
|
|
entry:
|
|
; CHECK-LABEL: @t
|
|
; CHECK: call arm_aapcs_vfpcc double @__exp10
|
|
%0 = call double @llvm.pow.f64(double 1.000000e+01, double %x)
|
|
ret double %0
|
|
}
|
|
|
|
; Function Attrs: nounwind readnone
|
|
declare double @llvm.pow.f64(double, double) #1
|
|
|
|
attributes #0 = { nounwind ssp }
|
|
attributes #1 = { nounwind readnone }
|