mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2025-02-14 17:34:41 +00:00
8a99824c5a
The revision I'm reverting breaks handling of transitive aliases. This blocks us and breaks sanitizer bootstrap: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/2651 (and checked locally by Alexey). This revision is the result of: svn merge -r204059:204058 -r204028:204027 -r203962:203961 . + the regression test added to test/MC/ELF/alias.s Another way to reproduce the regression with clang: $ cat q.c void a1(); void a2() __attribute__((alias("a1"))); void a3() __attribute__((alias("a2"))); void a1() {} $ ~/work/llvm-build/bin/clang-3.5-good -c q.c && mv q.o good.o && \ ~/work/llvm-build/bin/clang-3.5-bad -c q.c && mv q.o bad.o && \ objdump -t good.o bad.o good.o: file format elf64-x86-64 SYMBOL TABLE: 0000000000000000 l df *ABS* 0000000000000000 q.c 0000000000000000 l d .text 0000000000000000 .text 0000000000000000 l d .data 0000000000000000 .data 0000000000000000 l d .bss 0000000000000000 .bss 0000000000000000 l d .comment 0000000000000000 .comment 0000000000000000 l d .note.GNU-stack 0000000000000000 .note.GNU-stack 0000000000000000 l d .eh_frame 0000000000000000 .eh_frame 0000000000000000 g F .text 0000000000000006 a1 0000000000000000 g F .text 0000000000000006 a2 0000000000000000 g F .text 0000000000000006 a3 bad.o: file format elf64-x86-64 SYMBOL TABLE: 0000000000000000 l df *ABS* 0000000000000000 q.c 0000000000000000 l d .text 0000000000000000 .text 0000000000000000 l d .data 0000000000000000 .data 0000000000000000 l d .bss 0000000000000000 .bss 0000000000000000 l d .comment 0000000000000000 .comment 0000000000000000 l d .note.GNU-stack 0000000000000000 .note.GNU-stack 0000000000000000 l d .eh_frame 0000000000000000 .eh_frame 0000000000000000 g F .text 0000000000000006 a1 0000000000000000 g F .text 0000000000000006 a2 0000000000000000 g .text 0000000000000000 a3 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204137 91177308-0d34-0410-b5e6-96231b3b80d8
95 lines
2.7 KiB
C++
95 lines
2.7 KiB
C++
//===- lib/MC/MCSymbol.cpp - MCSymbol implementation ----------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/MC/MCSymbol.h"
|
|
#include "llvm/MC/MCExpr.h"
|
|
#include "llvm/Support/Debug.h"
|
|
#include "llvm/Support/raw_ostream.h"
|
|
using namespace llvm;
|
|
|
|
// Sentinel value for the absolute pseudo section.
|
|
const MCSection *MCSymbol::AbsolutePseudoSection =
|
|
reinterpret_cast<const MCSection *>(1);
|
|
|
|
static bool isAcceptableChar(char C) {
|
|
if ((C < 'a' || C > 'z') &&
|
|
(C < 'A' || C > 'Z') &&
|
|
(C < '0' || C > '9') &&
|
|
C != '_' && C != '$' && C != '.' && C != '@')
|
|
return false;
|
|
return true;
|
|
}
|
|
|
|
/// NameNeedsQuoting - Return true if the identifier \p Str needs quotes to be
|
|
/// syntactically correct.
|
|
static bool NameNeedsQuoting(StringRef Str) {
|
|
assert(!Str.empty() && "Cannot create an empty MCSymbol");
|
|
|
|
// If any of the characters in the string is an unacceptable character, force
|
|
// quotes.
|
|
for (unsigned i = 0, e = Str.size(); i != e; ++i)
|
|
if (!isAcceptableChar(Str[i]))
|
|
return true;
|
|
return false;
|
|
}
|
|
|
|
const MCSymbol &MCSymbol::AliasedSymbol() const {
|
|
const MCSymbol *S = this;
|
|
while (S->isVariable()) {
|
|
const MCExpr *Value = S->getVariableValue();
|
|
if (Value->getKind() != MCExpr::SymbolRef)
|
|
return *S;
|
|
const MCSymbolRefExpr *Ref = static_cast<const MCSymbolRefExpr*>(Value);
|
|
S = &Ref->getSymbol();
|
|
}
|
|
return *S;
|
|
}
|
|
|
|
void MCSymbol::setVariableValue(const MCExpr *Value) {
|
|
assert(!IsUsed && "Cannot set a variable that has already been used.");
|
|
assert(Value && "Invalid variable value!");
|
|
this->Value = Value;
|
|
|
|
// Variables should always be marked as in the same "section" as the value.
|
|
const MCSection *Section = Value->FindAssociatedSection();
|
|
if (Section)
|
|
setSection(*Section);
|
|
else
|
|
setUndefined();
|
|
}
|
|
|
|
void MCSymbol::print(raw_ostream &OS) const {
|
|
// The name for this MCSymbol is required to be a valid target name. However,
|
|
// some targets support quoting names with funny characters. If the name
|
|
// contains a funny character, then print it quoted.
|
|
StringRef Name = getName();
|
|
if (!NameNeedsQuoting(Name)) {
|
|
OS << Name;
|
|
return;
|
|
}
|
|
|
|
OS << '"';
|
|
for (unsigned I = 0, E = Name.size(); I != E; ++I) {
|
|
char C = Name[I];
|
|
if (C == '\n')
|
|
OS << "\\n";
|
|
else if (C == '"')
|
|
OS << "\\\"";
|
|
else
|
|
OS << C;
|
|
}
|
|
OS << '"';
|
|
}
|
|
|
|
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
|
|
void MCSymbol::dump() const {
|
|
print(dbgs());
|
|
}
|
|
#endif
|