mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2025-01-05 12:31:33 +00:00
b74b88edac
The reason this got reverted was that the @feat.00 symbol which was emitted for every TU became quoted, and on cygwin/mingw we use the gas assembler which couldn't handle the quotes. This commit fixes the problem by only emitting @feat.00 for win32, where we use clang -cc1as to assemble. gas would just drop this symbol anyway, so there is no loss there. With @feat.00 gone, there shouldn't be quoted symbols showing up on cygwin since it uses the Itanium ABI, which doesn't put these funny characters in symbols. > Because of win32 mangling, we produce symbol and section names with > funny characters in them, most notably @ characters. > > MC would choke on trying to parse its own assembly output. This patch addresses > that by: > > - Making @ trigger quoting of symbol names > - Also quote section names in the same way > - Just parse section names like other identifiers (to allow for quotes) > - Don't assume @ signifies a symbol variant if it is in a string. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@192859 91177308-0d34-0410-b5e6-96231b3b80d8
82 lines
2.4 KiB
C++
82 lines
2.4 KiB
C++
//===- lib/MC/MCSymbol.cpp - MCSymbol implementation ----------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/MC/MCSymbol.h"
|
|
#include "llvm/MC/MCExpr.h"
|
|
#include "llvm/Support/Debug.h"
|
|
#include "llvm/Support/raw_ostream.h"
|
|
using namespace llvm;
|
|
|
|
// Sentinel value for the absolute pseudo section.
|
|
const MCSection *MCSymbol::AbsolutePseudoSection =
|
|
reinterpret_cast<const MCSection *>(1);
|
|
|
|
static bool isAcceptableChar(char C) {
|
|
return (C >= 'a' && C <= 'z') ||
|
|
(C >= 'A' && C <= 'Z') ||
|
|
(C >= '0' && C <= '9') ||
|
|
C == '_' || C == '$' || C == '.';
|
|
}
|
|
|
|
/// NameNeedsQuoting - Return true if the identifier \p Str needs quotes to be
|
|
/// syntactically correct.
|
|
static bool NameNeedsQuoting(StringRef Str) {
|
|
assert(!Str.empty() && "Cannot create an empty MCSymbol");
|
|
|
|
// If any of the characters in the string is an unacceptable character, force
|
|
// quotes.
|
|
for (unsigned i = 0, e = Str.size(); i != e; ++i)
|
|
if (!isAcceptableChar(Str[i]))
|
|
return true;
|
|
return false;
|
|
}
|
|
|
|
const MCSymbol &MCSymbol::AliasedSymbol() const {
|
|
const MCSymbol *S = this;
|
|
while (S->isVariable()) {
|
|
const MCExpr *Value = S->getVariableValue();
|
|
if (Value->getKind() != MCExpr::SymbolRef)
|
|
return *S;
|
|
const MCSymbolRefExpr *Ref = static_cast<const MCSymbolRefExpr*>(Value);
|
|
S = &Ref->getSymbol();
|
|
}
|
|
return *S;
|
|
}
|
|
|
|
void MCSymbol::setVariableValue(const MCExpr *Value) {
|
|
assert(!IsUsed && "Cannot set a variable that has already been used.");
|
|
assert(Value && "Invalid variable value!");
|
|
this->Value = Value;
|
|
|
|
// Variables should always be marked as in the same "section" as the value.
|
|
const MCSection *Section = Value->FindAssociatedSection();
|
|
if (Section)
|
|
setSection(*Section);
|
|
else
|
|
setUndefined();
|
|
}
|
|
|
|
void MCSymbol::print(raw_ostream &OS) const {
|
|
// The name for this MCSymbol is required to be a valid target name. However,
|
|
// some targets support quoting names with funny characters. If the name
|
|
// contains a funny character, then print it quoted.
|
|
if (!NameNeedsQuoting(getName())) {
|
|
OS << getName();
|
|
return;
|
|
}
|
|
|
|
OS << '"' << getName() << '"';
|
|
}
|
|
|
|
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
|
|
void MCSymbol::dump() const {
|
|
print(dbgs());
|
|
}
|
|
#endif
|