mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2025-11-02 22:23:10 +00:00
b0d0a65e1d
Check that the `MDLocalVariable::getInlinedAt()` in a debug info
intrinsic's variable always matches the `MDLocation::getInlinedAt()` of
its `!dbg` attachment.
The goal here is to get rid of `MDLocalVariable::getInlinedAt()`
entirely (PR22778), since it's expensive and unnecessary, but I'll let
this verifier check bake for a while (a week maybe?) first. I've
updated the testcases that had the wrong value for `inlinedAt:`.
This checks that things are sane in the IR, but currently things go out
of whack in a few places in the backend. I'll follow shortly with
assertions in the backend (with code fixes).
If you have out-of-tree testcases that just started failing, here's how
I updated these ones:
1. The verifier check gives you the basic block, function, instruction,
and relevant metadata arguments (metadata numbering doesn't
necessarily match the source file, unfortunately).
2. Look at the `@llvm.dbg.*()` instruction, and compare the
`inlinedAt:` fields of the variable argument (second `metadata`
argument) and the `!dbg` attachment.
3. Figure out based on the variable `scope:` chain and the functions in
the file whether the variable has been inlined (and into what), so
you can determine which `inlinedAt:` is actually correct. In all of
the in-tree testcases, the `!MDLocation()` was correct and the
`!MDLocalVariable()` was wrong, but YMMV.
4. Duplicate the metadata that you're going to change, and add/drop the
`inlinedAt:` field from one of them. Be careful that the other
references to the same metadata node point at the correct one.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@234021 91177308-0d34-0410-b5e6-96231b3b80d8
58 lines
3.5 KiB
LLVM
58 lines
3.5 KiB
LLVM
; RUN: opt -mem2reg < %s | llvm-dis | grep ".dbg " | count 7
|
|
|
|
declare void @llvm.dbg.declare(metadata, metadata, metadata) nounwind readnone
|
|
|
|
declare void @foo(i32, i64, i8*)
|
|
|
|
define void @baz(i32 %a) nounwind ssp {
|
|
entry:
|
|
%x_addr.i = alloca i32 ; <i32*> [#uses=2]
|
|
%y_addr.i = alloca i64 ; <i64*> [#uses=2]
|
|
%z_addr.i = alloca i8* ; <i8**> [#uses=2]
|
|
%a_addr = alloca i32 ; <i32*> [#uses=2]
|
|
%"alloca point" = bitcast i32 0 to i32 ; <i32> [#uses=0]
|
|
call void @llvm.dbg.declare(metadata i32* %a_addr, metadata !0, metadata !MDExpression()), !dbg !7
|
|
store i32 %a, i32* %a_addr
|
|
%0 = load i32, i32* %a_addr, align 4, !dbg !8 ; <i32> [#uses=1]
|
|
call void @llvm.dbg.declare(metadata i32* %x_addr.i, metadata !9, metadata !MDExpression()) nounwind, !dbg !15
|
|
store i32 %0, i32* %x_addr.i
|
|
call void @llvm.dbg.declare(metadata i64* %y_addr.i, metadata !16, metadata !MDExpression()) nounwind, !dbg !15
|
|
store i64 55, i64* %y_addr.i
|
|
call void @llvm.dbg.declare(metadata i8** %z_addr.i, metadata !17, metadata !MDExpression()) nounwind, !dbg !15
|
|
store i8* bitcast (void (i32)* @baz to i8*), i8** %z_addr.i
|
|
%1 = load i32, i32* %x_addr.i, align 4, !dbg !18 ; <i32> [#uses=1]
|
|
%2 = load i64, i64* %y_addr.i, align 8, !dbg !18 ; <i64> [#uses=1]
|
|
%3 = load i8*, i8** %z_addr.i, align 8, !dbg !18 ; <i8*> [#uses=1]
|
|
call void @foo(i32 %1, i64 %2, i8* %3) nounwind, !dbg !18
|
|
br label %return, !dbg !19
|
|
|
|
return: ; preds = %entry
|
|
ret void, !dbg !19
|
|
}
|
|
|
|
!llvm.dbg.cu = !{!3}
|
|
!llvm.module.flags = !{!22}
|
|
!0 = !MDLocalVariable(tag: DW_TAG_arg_variable, name: "a", line: 8, arg: 0, scope: !1, file: !2, type: !6)
|
|
!1 = !MDSubprogram(name: "baz", linkageName: "baz", line: 8, isLocal: false, isDefinition: true, virtualIndex: 6, isOptimized: false, scopeLine: 8, file: !20, scope: !2, type: !4, function: void (i32)* @baz)
|
|
!2 = !MDFile(filename: "bar.c", directory: "/tmp/")
|
|
!3 = !MDCompileUnit(language: DW_LANG_C89, producer: "4.2.1 (Based on Apple Inc. build 5658) (LLVM build)", isOptimized: true, emissionKind: 0, file: !20, enums: !21, retainedTypes: !21)
|
|
!4 = !MDSubroutineType(types: !5)
|
|
!5 = !{null, !6}
|
|
!6 = !MDBasicType(tag: DW_TAG_base_type, name: "int", size: 32, align: 32, encoding: DW_ATE_signed)
|
|
!7 = !MDLocation(line: 8, scope: !1)
|
|
!8 = !MDLocation(line: 9, scope: !1)
|
|
!9 = !MDLocalVariable(tag: DW_TAG_arg_variable, name: "x", line: 4, arg: 0, scope: !10, file: !2, type: !6, inlinedAt: !8)
|
|
!10 = !MDSubprogram(name: "bar", linkageName: "bar", line: 4, isLocal: true, isDefinition: true, virtualIndex: 6, isOptimized: false, scopeLine: 4, file: !20, scope: !2, type: !11)
|
|
!11 = !MDSubroutineType(types: !12)
|
|
!12 = !{null, !6, !13, !14}
|
|
!13 = !MDBasicType(tag: DW_TAG_base_type, name: "long int", size: 64, align: 64, encoding: DW_ATE_signed)
|
|
!14 = !MDDerivedType(tag: DW_TAG_pointer_type, size: 64, align: 64, file: !20, scope: !2, baseType: null)
|
|
!15 = !MDLocation(line: 4, scope: !10, inlinedAt: !8)
|
|
!16 = !MDLocalVariable(tag: DW_TAG_arg_variable, name: "y", line: 4, arg: 0, scope: !10, file: !2, type: !13, inlinedAt: !8)
|
|
!17 = !MDLocalVariable(tag: DW_TAG_arg_variable, name: "z", line: 4, arg: 0, scope: !10, file: !2, type: !14, inlinedAt: !8)
|
|
!18 = !MDLocation(line: 5, scope: !10, inlinedAt: !8)
|
|
!19 = !MDLocation(line: 10, scope: !1)
|
|
!20 = !MDFile(filename: "bar.c", directory: "/tmp/")
|
|
!21 = !{}
|
|
!22 = !{i32 1, !"Debug Info Version", i32 3}
|