mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2025-02-21 21:29:41 +00:00
d0dbe02fd2
The C and C++ semantics for compare_exchange require it to return a bool
indicating success. This gets mapped to LLVM IR which follows each cmpxchg with
an icmp of the value loaded against the desired value.
When lowered to ldxr/stxr loops, this extra comparison is redundant: its
results are implicit in the control-flow of the function.
This commit makes two changes: it replaces that icmp with appropriate PHI
nodes, and then makes sure earlyCSE is called after expansion to actually make
use of the opportunities revealed.
I've also added -{arm,aarch64}-enable-atomic-tidy options, so that
existing fragile tests aren't perturbed too much by the change. Many
of them either rely on undef/unreachable too pervasively to be
restored to something well-defined (particularly while making sure
they test the same obscure assert from many years ago), or depend on a
particular CFG shape, which is disrupted by SimplifyCFG.
rdar://problem/16227836
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@209883 91177308-0d34-0410-b5e6-96231b3b80d8
90 lines
2.1 KiB
LLVM
90 lines
2.1 KiB
LLVM
; RUN: llc -mtriple=aarch64-apple-ios7.0 -o - %s | FileCheck %s
|
|
|
|
define i32 @test_return(i32* %p, i32 %oldval, i32 %newval) {
|
|
; CHECK-LABEL: test_return:
|
|
|
|
; CHECK: [[LOOP:LBB[0-9]+_[0-9]+]]:
|
|
; CHECK: ldaxr [[LOADED:w[0-9]+]], [x0]
|
|
; CHECK: cmp [[LOADED]], w1
|
|
; CHECK: b.ne [[FAILED:LBB[0-9]+_[0-9]+]]
|
|
|
|
; CHECK: stlxr [[STATUS:w[0-9]+]], {{w[0-9]+}}, [x0]
|
|
; CHECK: cbnz [[STATUS]], [[LOOP]]
|
|
|
|
; CHECK-NOT: cmp {{w[0-9]+}}, {{w[0-9]+}}
|
|
; CHECK: orr w0, wzr, #0x1
|
|
; CHECK: ret
|
|
|
|
; CHECK: [[FAILED]]:
|
|
; CHECK-NOT: cmp {{w[0-9]+}}, {{w[0-9]+}}
|
|
; CHECK: mov w0, wzr
|
|
; CHECK: ret
|
|
|
|
%loaded = cmpxchg i32* %p, i32 %oldval, i32 %newval seq_cst seq_cst
|
|
%success = icmp eq i32 %loaded, %oldval
|
|
%conv = zext i1 %success to i32
|
|
ret i32 %conv
|
|
}
|
|
|
|
define i1 @test_return_bool(i8* %value, i8 %oldValue, i8 %newValue) {
|
|
; CHECK-LABEL: test_return_bool:
|
|
|
|
; CHECK: [[LOOP:LBB[0-9]+_[0-9]+]]:
|
|
; CHECK: ldaxrb [[LOADED:w[0-9]+]], [x0]
|
|
; CHECK: cmp [[LOADED]], w1, uxtb
|
|
; CHECK: b.ne [[FAILED:LBB[0-9]+_[0-9]+]]
|
|
|
|
; CHECK: stlxrb [[STATUS:w[0-9]+]], {{w[0-9]+}}, [x0]
|
|
; CHECK: cbnz [[STATUS]], [[LOOP]]
|
|
|
|
; CHECK-NOT: cmp {{w[0-9]+}}, {{w[0-9]+}}
|
|
; CHECK: mov w0, wzr
|
|
; CHECK: ret
|
|
|
|
; CHECK: [[FAILED]]:
|
|
; CHECK-NOT: cmp {{w[0-9]+}}, {{w[0-9]+}}
|
|
; CHECK: orr w0, wzr, #0x1
|
|
; CHECK: ret
|
|
|
|
%loaded = cmpxchg i8* %value, i8 %oldValue, i8 %newValue acq_rel monotonic
|
|
%failure = icmp ne i8 %loaded, %oldValue
|
|
ret i1 %failure
|
|
}
|
|
|
|
define void @test_conditional(i32* %p, i32 %oldval, i32 %newval) {
|
|
; CHECK-LABEL: test_conditional:
|
|
|
|
; CHECK: [[LOOP:LBB[0-9]+_[0-9]+]]:
|
|
; CHECK: ldaxr [[LOADED:w[0-9]+]], [x0]
|
|
; CHECK: cmp [[LOADED]], w1
|
|
; CHECK: b.ne [[FAILED:LBB[0-9]+_[0-9]+]]
|
|
|
|
; CHECK: stlxr [[STATUS:w[0-9]+]], w2, [x0]
|
|
; CHECK: cbnz [[STATUS]], [[LOOP]]
|
|
|
|
; CHECK-NOT: cmp {{w[0-9]+}}, {{w[0-9]+}}
|
|
; CHECK: b _bar
|
|
|
|
; CHECK: [[FAILED]]:
|
|
; CHECK-NOT: cmp {{w[0-9]+}}, {{w[0-9]+}}
|
|
; CHECK: b _baz
|
|
|
|
%loaded = cmpxchg i32* %p, i32 %oldval, i32 %newval seq_cst seq_cst
|
|
%success = icmp eq i32 %loaded, %oldval
|
|
br i1 %success, label %true, label %false
|
|
|
|
true:
|
|
tail call void @bar() #2
|
|
br label %end
|
|
|
|
false:
|
|
tail call void @baz() #2
|
|
br label %end
|
|
|
|
end:
|
|
ret void
|
|
}
|
|
|
|
declare void @bar()
|
|
declare void @baz()
|