Chandler Carruth bfed08e41f
[x86] Start fixing a really subtle and terrible form of miscompile in ...
these DAG combines.
The DAG auto-CSE thing is truly terrible. Due to it, when RAUW-ing
a node with its operand, you can cause its uses to CSE to itself, which
then causes their uses to become your uses which causes them to be
picked up by the RAUW. For nodes that are determined to be "no-ops",
this is "fine". But if the RAUW is one of several steps to enact
a transformation, this causes the DAG to really silently eat an discard
nodes that you would never expect. It took days for me to actually
pinpoint a test case triggering this and a really frustrating amount of
time to even comprehend the bug because I never even thought about the
ability of RAUW to iteratively consume nodes due to CSE-ing them into
itself.
To fix this, we have to build up a brand-new chain of operations any
time we are combining across (potentially) intervening nodes. But once
the logic is added to do this, another issue surfaces: CombineTo eagerly
deletes the one node combined, *but no others*. This is... really
frustrating. If deleting it makes its operands become dead, those
operand nodes often won't go onto the worklist in the
order you would want -- they're already on it and not near the top. That
means things higher on the worklist will get combined prior to these
dead nodes being GCed out of the worklist, and if the chain is long, the
immediate users won't be enough to re-detect where the root of the chain
is that became single-use again after deleting the dead nodes. The
better way to do this is to never immediately delete nodes, and instead
to just enqueue them so we can recursively delete them. The
combined-from node is typically not on the worklist anyways by virtue of
having been popped off.... But that in turn breaks other tests that
*require* CombineTo to delete unused nodes. :: sigh ::
Fortunately, there is a better way. This whole routine should have been
returning the replacement rather than using CombineTo which is quite
hacky. Switch to that, and all the pieces fall together.
I suspect the same kind of miscompile is possible in the half-shuffle
folding code, and potentially the recursive folding code. I'll be
switching those over to a pattern more like this one for safety's sake
even though I don't immediately have any test cases for them. Note that
the only way I got a test case for this instance was with *heavily* DAG
combined 256-bit shuffle sequences generated by my fuzzer. ;]
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@216319 91177308-0d34-0410-b5e6-96231b3b80d8
2014-08-23 10:25:15 +00:00
2014-06-09 22:42:55 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-04-12 00:59:48 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-06-25 12:41:52 +00:00
2014-07-30 22:51:54 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-07-15 03:00:41 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-05-28 18:15:43 +00:00
2014-03-12 20:15:49 +00:00
2014-03-21 17:38:01 +00:00
2014-02-13 15:38:16 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-06-25 12:41:52 +00:00
2014-02-13 14:44:26 +00:00
2014-02-19 17:23:20 +00:00
2014-02-13 14:44:26 +00:00
2014-07-01 18:53:31 +00:00
2014-07-24 22:15:28 +00:00
2014-02-13 14:44:26 +00:00
2014-08-06 00:21:25 +00:00
2014-08-05 23:57:31 +00:00
2014-08-06 00:21:25 +00:00
2014-07-25 16:10:16 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-08-06 00:21:25 +00:00
2014-02-11 21:46:46 +00:00
2014-06-13 14:24:07 +00:00
2014-08-06 00:21:25 +00:00
2014-02-16 07:31:05 +00:00
2014-02-13 14:44:26 +00:00
2014-08-02 00:50:10 +00:00
2014-07-25 16:05:18 +00:00
2014-07-25 16:05:18 +00:00
2014-07-28 22:24:06 +00:00
2014-06-09 14:20:23 +00:00
2014-06-09 12:32:53 +00:00
2014-07-15 16:24:24 +00:00
2014-07-16 22:40:28 +00:00
2014-08-21 09:43:43 +00:00
2014-07-30 22:51:54 +00:00
2014-08-20 19:58:59 +00:00
2014-08-07 09:41:19 +00:00
2014-03-31 22:14:04 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-04-19 22:45:44 +00:00
2014-04-01 08:13:07 +00:00
2014-06-03 21:01:39 +00:00
2014-07-01 18:53:31 +00:00
2014-07-01 18:53:31 +00:00
2014-07-01 18:53:31 +00:00
2014-07-01 18:53:31 +00:00
2014-07-14 15:31:13 +00:00
2014-07-01 18:53:31 +00:00
2014-07-01 18:53:31 +00:00
2014-07-01 18:53:31 +00:00
2014-07-01 18:53:31 +00:00
2014-07-14 16:28:13 +00:00
2014-07-01 18:53:31 +00:00
2014-05-20 19:25:04 +00:00
2014-04-10 00:27:43 +00:00
2014-05-27 03:42:20 +00:00
2014-03-25 12:36:38 +00:00
2014-03-26 00:10:22 +00:00
2014-02-18 11:15:32 +00:00
2014-05-31 00:52:23 +00:00
2014-03-26 00:10:22 +00:00
2014-04-09 23:28:11 +00:00
2014-03-27 09:45:08 +00:00
2014-02-11 07:25:59 +00:00
2014-08-18 11:59:06 +00:00
2014-06-18 14:04:37 +00:00
2014-08-14 17:13:33 +00:00
2014-05-12 07:18:51 +00:00
2014-07-02 14:11:05 +00:00
2014-04-09 12:37:50 +00:00
2014-08-12 21:13:12 +00:00
2014-07-28 13:46:45 +00:00
2014-08-06 15:40:34 +00:00
2014-06-18 16:51:10 +00:00
2014-08-21 13:28:02 +00:00
2014-08-13 07:58:43 +00:00
2014-08-18 11:59:06 +00:00
2014-08-13 00:30:05 +00:00
2014-08-04 14:35:15 +00:00
2014-07-28 13:46:45 +00:00
2014-07-28 13:46:45 +00:00
2014-08-13 10:46:00 +00:00
2014-08-02 10:27:38 +00:00
2014-06-25 17:41:58 +00:00
2014-03-17 17:06:14 +00:00
2014-06-25 12:41:52 +00:00
2014-07-27 01:15:58 +00:00
2014-08-15 03:54:49 +00:00
2014-02-12 23:42:28 +00:00
2014-06-25 17:41:58 +00:00
2014-08-02 10:27:38 +00:00
2014-03-05 19:41:16 +00:00
2014-02-11 15:42:46 +00:00
2014-06-25 17:41:58 +00:00
2014-06-25 17:41:58 +00:00
2014-03-17 01:22:54 +00:00
2014-05-19 19:45:57 +00:00
2014-05-21 22:00:39 +00:00
2014-07-23 07:08:53 +00:00
2014-04-22 07:40:34 +00:00
2014-04-19 13:47:43 +00:00
2014-07-03 07:04:38 +00:00
2014-08-06 18:09:15 +00:00
2014-03-26 12:52:28 +00:00
2014-03-28 21:40:47 +00:00
2014-02-13 14:44:26 +00:00
2014-05-05 16:47:07 +00:00
2014-03-13 23:18:37 +00:00
2014-06-06 21:08:55 +00:00
2014-03-11 10:48:52 +00:00
2014-06-13 17:29:39 +00:00
2014-06-13 17:29:39 +00:00
2014-06-13 14:24:07 +00:00
2014-04-12 00:59:48 +00:00
2014-05-13 15:42:45 +00:00
2014-04-12 00:59:48 +00:00
2014-06-27 18:19:56 +00:00
2014-06-27 18:19:56 +00:00
2014-06-27 18:19:56 +00:00
2014-05-30 23:17:53 +00:00
2014-05-15 15:18:15 +00:00
2014-05-15 15:18:15 +00:00
2014-07-15 00:02:32 +00:00
2014-05-08 17:44:04 +00:00
2014-05-15 15:45:31 +00:00
2014-08-13 16:09:40 +00:00
2014-07-19 07:52:58 +00:00
2014-07-21 07:30:54 +00:00
2014-08-16 00:29:44 +00:00
2014-03-18 17:12:59 +00:00
2014-05-30 15:00:45 +00:00
2014-04-02 22:21:01 +00:00
2014-05-05 18:10:15 +00:00
2014-07-15 03:00:39 +00:00
2014-07-14 22:57:27 +00:00
2014-02-13 14:44:26 +00:00
2014-08-20 18:03:00 +00:00
2014-07-17 11:12:12 +00:00
2014-06-12 16:04:47 +00:00
2014-03-06 22:47:08 +00:00
2014-07-25 16:10:16 +00:00
2014-03-13 20:31:19 +00:00
2014-07-23 07:08:53 +00:00
2014-07-30 22:51:54 +00:00
2014-07-30 22:51:54 +00:00
2014-02-11 21:46:46 +00:00
2014-03-09 06:41:58 +00:00
2014-06-27 18:19:56 +00:00
2014-06-27 18:19:56 +00:00
2014-08-02 10:27:38 +00:00
2014-04-26 02:58:04 +00:00
2014-04-18 10:45:33 +00:00
2014-06-13 12:05:06 +00:00
2014-06-12 20:12:34 +00:00
2014-06-13 00:45:11 +00:00
2014-06-16 23:58:24 +00:00
2014-08-19 19:44:10 +00:00
2014-06-17 21:55:43 +00:00
2014-08-19 19:44:13 +00:00
2014-06-12 23:27:57 +00:00
2014-08-19 19:44:10 +00:00
2014-06-23 21:55:36 +00:00
2014-06-23 21:55:36 +00:00
2014-06-25 20:06:12 +00:00
2014-06-23 21:55:44 +00:00
2014-06-23 21:55:40 +00:00
2014-06-23 21:55:36 +00:00
2014-06-13 02:21:58 +00:00
2014-07-30 22:51:54 +00:00
2014-08-19 19:44:10 +00:00
2014-02-13 14:44:26 +00:00
2014-07-03 15:06:47 +00:00
2014-05-07 22:52:58 +00:00
2014-07-17 17:14:35 +00:00
2014-08-16 22:28:37 +00:00
2014-05-19 19:45:57 +00:00
2014-02-13 14:44:26 +00:00
2014-08-19 02:09:57 +00:00
2014-08-07 09:41:19 +00:00
2014-06-25 12:41:52 +00:00
2014-05-20 21:25:34 +00:00
2014-06-12 10:53:48 +00:00
2014-06-19 10:29:41 +00:00
2014-07-18 13:01:25 +00:00
2014-03-21 17:16:11 +00:00
2014-07-24 22:15:28 +00:00
2014-03-09 06:41:58 +00:00
2014-03-09 06:41:58 +00:00
2014-07-24 19:53:33 +00:00
2014-03-09 06:41:58 +00:00
2014-03-09 06:41:58 +00:00
2014-04-29 10:06:10 +00:00
2014-02-13 14:44:26 +00:00
2014-08-01 22:19:41 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-03-28 23:28:07 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-03-26 16:30:54 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-04-12 00:59:48 +00:00
2014-03-11 15:49:24 +00:00
2014-07-24 22:15:28 +00:00
2014-07-30 22:51:54 +00:00
2014-06-05 19:29:43 +00:00
2014-06-05 19:29:43 +00:00
2014-08-20 11:59:22 +00:00
2014-08-20 11:59:22 +00:00
2014-08-20 11:59:22 +00:00
2014-08-20 11:59:22 +00:00
2014-08-20 11:59:22 +00:00
2014-06-18 11:52:44 +00:00
2014-06-09 22:42:55 +00:00
2014-05-14 21:14:37 +00:00
2014-07-24 22:15:28 +00:00
2014-04-15 19:30:48 +00:00
2014-03-21 06:04:45 +00:00
2014-03-18 18:17:59 +00:00
2014-05-19 20:38:59 +00:00
2014-08-06 00:21:25 +00:00
2014-06-27 18:19:56 +00:00
2014-05-20 19:25:04 +00:00
2014-02-13 14:44:26 +00:00
2014-08-02 00:50:10 +00:00
2014-04-12 00:59:48 +00:00
2014-04-12 00:59:48 +00:00
2014-02-26 22:07:26 +00:00
2014-05-06 01:20:42 +00:00
2014-03-11 00:44:14 +00:00
2014-08-01 21:54:37 +00:00
2014-03-13 13:36:25 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-02-13 14:44:26 +00:00
2014-08-06 18:09:04 +00:00
2014-04-29 23:55:41 +00:00
2014-04-29 23:55:41 +00:00
2014-05-06 16:51:25 +00:00
2014-05-06 16:51:25 +00:00
2014-07-23 07:08:53 +00:00
2014-03-21 06:04:45 +00:00
2014-03-11 10:48:52 +00:00
2014-06-25 05:31:22 +00:00
2014-08-19 19:44:06 +00:00
2014-02-13 14:44:26 +00:00
2014-02-19 17:23:20 +00:00
2014-07-31 00:11:11 +00:00
2014-07-31 00:11:16 +00:00
2014-05-14 16:14:45 +00:00
2014-04-03 20:07:51 +00:00
2014-03-20 21:38:04 +00:00
2014-03-21 00:30:24 +00:00
2014-07-26 03:46:54 +00:00
2014-02-25 20:01:08 +00:00
2014-07-01 18:53:31 +00:00
2014-07-24 22:15:28 +00:00
2014-03-05 20:09:15 +00:00
2014-07-03 15:19:40 +00:00
2014-06-25 03:05:47 +00:00
2014-02-19 17:23:20 +00:00
2014-07-07 23:25:23 +00:00
2014-02-28 23:05:31 +00:00
2014-03-21 21:46:24 +00:00
2014-04-11 21:51:09 +00:00
2014-06-30 17:14:21 +00:00
2014-04-24 20:14:08 +00:00
2014-04-30 19:17:32 +00:00
2014-05-22 16:21:39 +00:00
2014-08-08 08:21:19 +00:00
2014-03-12 21:20:55 +00:00
2014-04-10 22:58:43 +00:00
2014-05-22 13:03:43 +00:00
2014-08-04 21:29:59 +00:00
2014-03-22 01:47:22 +00:00
2014-07-10 18:21:04 +00:00
2014-02-22 07:27:04 +00:00
2014-07-13 21:02:14 +00:00
2014-06-11 23:11:02 +00:00
2014-03-07 23:25:55 +00:00
2014-06-25 13:12:54 +00:00
2014-03-17 18:58:01 +00:00
2014-05-12 13:12:08 +00:00
2014-06-25 10:02:21 +00:00
2014-07-23 11:20:24 +00:00
2014-05-17 03:29:20 +00:00
2014-08-20 20:34:56 +00:00
2014-07-24 01:28:21 +00:00
2014-07-25 19:31:34 +00:00
2014-03-26 16:30:54 +00:00
2014-08-06 00:21:25 +00:00
2014-04-17 19:08:36 +00:00
2014-06-12 03:29:26 +00:00
2014-06-26 23:39:52 +00:00
2014-07-25 04:50:08 +00:00
2014-07-24 20:40:55 +00:00
2014-08-01 18:26:27 +00:00
2014-05-20 17:40:03 +00:00
2014-07-24 22:15:28 +00:00
2014-03-26 17:27:01 +00:00
2014-07-08 15:22:29 +00:00
2014-07-08 15:22:29 +00:00
2014-07-24 22:09:56 +00:00
2014-08-20 19:00:37 +00:00
2014-02-16 07:31:05 +00:00
2014-07-10 18:00:53 +00:00
2014-04-18 21:10:11 +00:00
2014-07-24 22:15:28 +00:00
2014-02-27 09:24:31 +00:00
2014-08-22 21:59:26 +00:00
2014-08-22 21:59:26 +00:00
2014-07-10 12:32:32 +00:00
2014-07-23 07:08:53 +00:00
2014-08-05 20:16:35 +00:00
2014-08-14 15:15:28 +00:00
2014-07-16 15:37:08 +00:00
2014-07-15 02:44:49 +00:00
2014-02-28 18:44:39 +00:00
2014-02-26 21:39:12 +00:00
2014-02-12 23:42:28 +00:00
2014-02-10 12:42:13 +00:00
2014-03-25 17:47:06 +00:00
2014-04-18 19:44:16 +00:00
2014-08-02 11:17:41 +00:00
2014-08-11 23:49:33 +00:00
2014-06-21 12:56:42 +00:00
2014-07-07 19:03:32 +00:00
2014-07-26 10:58:14 +00:00
2014-08-16 09:42:15 +00:00
2014-08-16 09:42:15 +00:00
2014-08-13 01:25:45 +00:00
2014-08-23 00:45:03 +00:00
2014-08-23 10:25:15 +00:00
2014-07-02 15:09:44 +00:00
2014-03-27 09:45:08 +00:00
2014-08-21 13:28:02 +00:00
2014-02-07 16:21:30 +00:00
2014-07-24 22:15:28 +00:00
2014-07-09 10:06:58 +00:00
2014-07-08 08:45:38 +00:00
2014-07-24 22:15:28 +00:00
2014-07-09 10:58:18 +00:00
2014-07-24 22:15:28 +00:00
2014-07-10 18:04:55 +00:00
2014-05-09 22:32:13 +00:00
2014-08-04 21:05:27 +00:00
2014-06-25 12:41:52 +00:00
2014-07-15 02:34:12 +00:00
2014-06-07 21:23:09 +00:00
2014-07-30 22:51:54 +00:00
2014-05-12 22:01:27 +00:00
2014-08-07 09:41:19 +00:00
2014-06-17 23:22:41 +00:00
2014-07-24 22:15:28 +00:00
2014-07-30 20:26:09 +00:00
2014-07-24 22:15:28 +00:00
2014-05-29 23:52:53 +00:00
2014-08-19 19:44:06 +00:00
bfed08e41f