mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2024-12-30 17:33:24 +00:00
36b699f2b1
This requires a number of steps. 1) Move value_use_iterator into the Value class as an implementation detail 2) Change it to actually be a *Use* iterator rather than a *User* iterator. 3) Add an adaptor which is a User iterator that always looks through the Use to the User. 4) Wrap these in Value::use_iterator and Value::user_iterator typedefs. 5) Add the range adaptors as Value::uses() and Value::users(). 6) Update *all* of the callers to correctly distinguish between whether they wanted a use_iterator (and to explicitly dig out the User when needed), or a user_iterator which makes the Use itself totally opaque. Because #6 requires churning essentially everything that walked the Use-Def chains, I went ahead and added all of the range adaptors and switched them to range-based loops where appropriate. Also because the renaming requires at least churning every line of code, it didn't make any sense to split these up into multiple commits -- all of which would touch all of the same lies of code. The result is still not quite optimal. The Value::use_iterator is a nice regular iterator, but Value::user_iterator is an iterator over User*s rather than over the User objects themselves. As a consequence, it fits a bit awkwardly into the range-based world and it has the weird extra-dereferencing 'operator->' that so many of our iterators have. I think this could be fixed by providing something which transforms a range of T&s into a range of T*s, but that *can* be separated into another patch, and it isn't yet 100% clear whether this is the right move. However, this change gets us most of the benefit and cleans up a substantial amount of code around Use and User. =] git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203364 91177308-0d34-0410-b5e6-96231b3b80d8 |
||
---|---|---|
.. | ||
Argument.h | ||
AssemblyAnnotationWriter.h | ||
Attributes.h | ||
AutoUpgrade.h | ||
BasicBlock.h | ||
CallingConv.h | ||
CallSite.h | ||
CFG.h | ||
CMakeLists.txt | ||
Constant.h | ||
ConstantFolder.h | ||
ConstantRange.h | ||
Constants.h | ||
DataLayout.h | ||
DebugInfo.h | ||
DebugLoc.h | ||
DerivedTypes.h | ||
DiagnosticInfo.h | ||
DiagnosticPrinter.h | ||
DIBuilder.h | ||
Dominators.h | ||
Function.h | ||
GetElementPtrTypeIterator.h | ||
GlobalAlias.h | ||
GlobalValue.h | ||
GlobalVariable.h | ||
GVMaterializer.h | ||
InlineAsm.h | ||
InstIterator.h | ||
InstrTypes.h | ||
Instruction.def | ||
Instruction.h | ||
Instructions.h | ||
InstVisitor.h | ||
IntrinsicInst.h | ||
Intrinsics.h | ||
Intrinsics.td | ||
IntrinsicsAArch64.td | ||
IntrinsicsARM.td | ||
IntrinsicsHexagon.td | ||
IntrinsicsMips.td | ||
IntrinsicsNVVM.td | ||
IntrinsicsPowerPC.td | ||
IntrinsicsR600.td | ||
IntrinsicsX86.td | ||
IntrinsicsXCore.td | ||
IRBuilder.h | ||
IRPrintingPasses.h | ||
LeakDetector.h | ||
LegacyPassManager.h | ||
LegacyPassManagers.h | ||
LegacyPassNameParser.h | ||
LLVMContext.h | ||
Mangler.h | ||
MDBuilder.h | ||
Metadata.h | ||
Module.h | ||
NoFolder.h | ||
OperandTraits.h | ||
Operator.h | ||
PassManager.h | ||
PatternMatch.h | ||
PredIteratorCache.h | ||
SymbolTableListTraits.h | ||
Type.h | ||
TypeBuilder.h | ||
TypeFinder.h | ||
Use.h | ||
User.h | ||
Value.h | ||
ValueHandle.h | ||
ValueMap.h | ||
ValueSymbolTable.h | ||
Verifier.h |