6502/millfork
1
0
Fork 0
mirror of https://github.com/KarolS/millfork.git synced 2024-11-01 05:05:32 +00:00
Code Issues Projects Releases Wiki Activity

Detect obviously overflowing constants

Browse Source
This commit is contained in:
Karol Stasiak 2020-03-15 01:01:08 +01:00
parent ab597e2dbe
commit 24870ae62e
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/main/scala/millfork/env/Environment.scala vendored
View File

@ -1708,7 +1708,15 @@ class Environment(val parent: Option[Environment], val prefix: String, val cpuFa
if (stmt.register) log.error(s"`$name` is a constant and cannot be in a register", position)
if (stmt.address.isDefined) log.error(s"`$name` is a constant and cannot have an address", position)
if (stmt.initialValue.isEmpty) log.error(s"`$name` is a constant and requires a value", position)
val constantValue: Constant = stmt.initialValue.flatMap(eval).getOrElse(errorConstant(s"`$name` has a non-constant value", position)).fitInto(typ)
val rawConstantValue = stmt.initialValue.flatMap(eval).getOrElse(errorConstant(s"`$name` has a non-constant value", position)).quickSimplify
rawConstantValue match {
case NumericConstant(nv, _) if nv >= 2 =>
if (nv >= 1.<<(8*typ.size)) {
log.error(s"Constant value $nv too big for type ${typ.name}", stmt.position)
}
case _ => // ignore
}
val constantValue = rawConstantValue.fitInto(typ)
if (constantValue.requiredSize > typ.size) log.error(s"`$name` is has an invalid value: not in the range of `$typ`", position)
addThing(ConstantThing(prefix + name, constantValue, typ), stmt.position)
for(Subvariable(suffix, offset, t, arraySize) <- getSubvariables(typ)) {