mirror of
https://github.com/oliverschmidt/contiki.git
synced 2024-09-07 11:54:27 +00:00
Added boundary checks when parsing CoAP packets.
Thanks to Stephan Zeisberg for reporting this issue.
This commit is contained in:
parent
ea4e080bae
commit
576ca6457f
@ -529,8 +529,21 @@ coap_parse_message(void *packet, uint8_t *data, uint16_t data_len)
|
||||
++current_option;
|
||||
}
|
||||
|
||||
if(current_option + option_length > data + data_len) {
|
||||
/* Malformed CoAP - out of bounds */
|
||||
PRINTF("BAD REQUEST: options outside data packet: %u > %u\n",
|
||||
(unsigned)(current_option + option_length - data), data_len);
|
||||
return BAD_REQUEST_4_00;
|
||||
}
|
||||
|
||||
option_number += option_delta;
|
||||
|
||||
if(option_number > COAP_OPTION_SIZE1) {
|
||||
/* Malformed CoAP - out of bounds */
|
||||
PRINTF("BAD REQUEST: option number too large: %u\n", option_number);
|
||||
return BAD_REQUEST_4_00;
|
||||
}
|
||||
|
||||
PRINTF("OPTION %u (delta %u, len %zu): ", option_number, option_delta,
|
||||
option_length);
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user