mirror of
https://github.com/oliverschmidt/contiki.git
synced 2024-11-04 13:06:38 +00:00
24d15ad9a5
An off-by-one error in resolv_found() could make an strncat() call
overflow by the terminating null byte.
When building with Clang the following warning was shown:
../../../core/net/ip/resolv.c:1458:17: warning: the value of the
size argument in 'strncat' is too large, might lead to a
buffer overflow [-Wstrncat-size]
sizeof(resolv_hostname) - strlen(resolv_hostname));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../../core/net/ip/resolv.c:1458:17: note: change the argument to
be the free space in the destination buffer minus the
terminating null byte
sizeof(resolv_hostname) - strlen(resolv_hostname));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sizeof(resolv_hostname) - strlen(resolv_hostname) - 1
Signed-off-by: Joakim Gebart <joakim.gebart@eistec.se>
|
||
|---|---|---|
| .. | ||
| cfs | ||
| ctk | ||
| dev | ||
| lib | ||
| loader | ||
| net | ||
| sys | ||
| contiki-default-conf.h | ||
| contiki-lib.h | ||
| contiki-net.h | ||
| contiki-version.h | ||
| contiki.h | ||