mirror of
https://github.com/oliverschmidt/contiki.git
synced 2024-12-21 19:29:18 +00:00
7f48057b9e
The leds API did not work in some cases. E.g. with the following sequence: leds_off(LEDS_ALL); leds_toggle(LEDS_GREEN); leds_off(LEDS_ALL); the green LED was remaining on after the last call. This was caused by the toggle feature made synonymous with the invert feature, although it is unrelated. leds_toggle() is indeed supposed to toggle an LED, while leds_invert() is supposed to change the active level of an LED. However, all users of leds_invert() actually meant leds_toggle(), and the invert feature does not make sense in this module because it is not handy due to successive calls to leds_invert() changing the intended behavior, and hardware active levels should be managed in leds_arch_set() (e.g. by XORing the passed value with a hardware-specific constant before setting the output levels of the pins). Consequently, this change: - removes the leds_invert() function, - makes leds_toggle() behave as expected relatively to leds_off() / leds_on(), - sanitizes the code in the leds module. Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com> |
||
|---|---|---|
| .. | ||
| battery-sensor.h | ||
| button-sensor.h | ||
| cc2420_const.h | ||
| cc2420-aes.c | ||
| cc2420-aes.h | ||
| cc2420.c | ||
| cc2420.h | ||
| cc2520_const.h | ||
| cc2520.c | ||
| cc2520.h | ||
| ds2411.c | ||
| ds2411.h | ||
| eeprom.h | ||
| leds.c | ||
| leds.h | ||
| nullradio.c | ||
| nullradio.h | ||
| radio-sensor.h | ||
| radio.h | ||
| rom.h | ||
| serial-line.c | ||
| serial-line.h | ||
| sht11-sensor.c | ||
| sht11-sensor.h | ||
| sht11.c | ||
| sht11.h | ||
| slip.c | ||
| slip.h | ||
| spi.h | ||
| watchdog.h | ||
| xmem.h | ||