mirror of
https://github.com/oliverschmidt/contiki.git
synced 2024-12-22 10:30:13 +00:00
cb0510ebcf
According to [1], we should disable non-maskable and maskable interrupts while initializing RTC. Otherwise, the RTC may be left in an undefined state (non-functional) if an interrupt occurs. Currently, maskable interrupts are already disabled, but NMI is not. This patch adds helpers APIs to enable/disable non-maskable interrupts (NMI) and changes rtc_init() to disable NMI while initializing the RTC. NMI enable/disable code is legacy-PC specific therefore it was put in driver/legacy_pc/ directory. Regarding the RTC initialization changes, just calling nmi_disable() and nmi_enable is not enough since NMI and RTC share the same IO port. So We should also set the NMI_ENABLE bit while selecting the RTC_INDEX. Additionally, the nmi_disable() call is not strictly required since we set the NMI_ENABLE bit while selecting the RTC_INDEX. However, to make clear hat we are disabling NMI and to improve readability (by matching NMI disable/enable), the nmi_disable() call was purposely used. [1] http://wiki.osdev.org/RTC |
||
|---|---|---|
| .. | ||
| 6502 | ||
| arm | ||
| avr | ||
| cc26xx-cc13xx | ||
| cc253x | ||
| cc2430 | ||
| cc2538 | ||
| mc1322x | ||
| msp430 | ||
| native | ||
| pic32 | ||
| rl78 | ||
| stm32w108 | ||
| x86 | ||