Apple-2-SW/lawless-legends
1
0
Fork 0
mirror of https://github.com/badvision/lawless-legends.git synced 2025-03-01 03:30:04 +00:00
Code Issues Projects Releases Wiki Activity

Minor performance improvements

Browse Source
This commit is contained in:
Brendan Robert 2021-04-02 15:07:45 -05:00
parent d9061488f4
commit 6ede1e27ed
2 changed files with 12 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
Platform/Apple/tools/jace/src/main/java/jace/core/Device.java
View File

@ -24,8 +24,7 @@ import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
import java.util.List;
import javafx.beans.property.BooleanProperty;
import javafx.beans.property.SimpleBooleanProperty;
import java.util.concurrent.atomic.AtomicBoolean;
/**
* Device is a very simple abstraction of any emulation component. A device
@ -58,7 +57,7 @@ public abstract class Device implements Reconfigurable {
@Stateful
private int waitCycles = 0;
@Stateful
private final BooleanProperty run = new SimpleBooleanProperty(true);
private boolean run = true;
@Stateful
public boolean isPaused = false;
@Stateful
@ -87,7 +86,7 @@ public abstract class Device implements Reconfigurable {
return Collections.unmodifiableList(children);
}
public BooleanProperty getRunningProperty() {
public boolean getRunningProperty() {
return run;
}
@ -100,38 +99,24 @@ public abstract class Device implements Reconfigurable {
}
public void doTick() {
/*
if (waitCycles <= 0)
tick();
else
waitCycles--;
*/
if (!run.get()) {
// System.out.println("Device stopped: " + getName());
isPaused = true;
return;
}
// The following might be as much as 7% faster than the above
// My guess is that the above results in a GOTO
// whereas the following pre-emptive return avoids that
if (waitCycles > 0) {
if (run) {
children.forEach(Device::tick);
if (waitCycles <= 0) {
tick();
return;
}
waitCycles--;
return;
}
// Implicit else...
children.forEach(Device::doTick);
tick();
}
public boolean isRunning() {
return run.get();
return run;
}
public synchronized void setRun(boolean run) {
// System.out.println(Thread.currentThread().getName() + (run ? " resuming " : " suspending ")+ getDeviceName());
isPaused = false;
this.run.set(run);
this.run = run;
}
protected abstract String getDeviceName();

2
Platform/Apple/tools/jace/src/main/java/jace/hardware/ZipWarpAccelerator.java
View File

@ -195,7 +195,7 @@ public class ZipWarpAccelerator extends Device {
@Override
public void tick() {
if (zipUnlockCount > 0) {
if (zipUnlockCount > 0.0) {
zipUnlockCount -= UNLOCK_PENALTY_PER_TICK;
}
}