Apple-2-SW/prog8
1
0
Fork 0
mirror of https://github.com/irmen/prog8.git synced 2024-07-26 05:29:15 +00:00
Code Issues Projects Releases Wiki Activity

fix some problems with subroutine parameters

Browse Source
This commit is contained in:
Irmen de Jong 2018-11-26 01:18:06 +01:00
parent 43c99f1d89
commit 30e2bdad79
3 changed files with 37 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
compiler/examples/test.p8
View File

@ -18,30 +18,30 @@ sub start() {
word[10] wordarray
c64.CHROUT(X)
c64.CHROUT(b1) ; @todo fix compiler crash expression identifierref should be a vardef, not null
c64.CHROUT(ub1) ; @todo fix compiler crash expression identifierref should be a vardef, not null
c64.CHROUT(mb1) ; @todo fix compiler crash "
c64.CHROUT(mub1) ; @todo fix compiler crash "
c64.CHROUT(bytearray[1]) ; @todo fix compiler crash null cannot be cast to non-null type prog8.ast.VarDecl
c64.CHROUT(ubytearray[1]) ; @todo fix compiler crash null cannot be cast to non-null type prog8.ast.VarDecl
c64.CHROUT(membytearray[1]) ; @todo fix compiler crash null cannot be cast to non-null type prog8.ast.VarDecl
c64.CHROUT(memubytearray[1]) ; @todo fix compiler crash null cannot be cast to non-null type prog8.ast.VarDecl
c64.CHROUT(ubytearray[X]) ; @todo fix compiler crash "
c64.CHROUT(memubytearray[X]) ; @todo fix compiler crash "
c64.CHROUT(wordarray[1]) ; @todo fix compiler crash "
c64.CHROUT(ub1)
c64.CHROUT(mub1)
c64.CHROUT(ubytearray[1])
c64.CHROUT(memubytearray[1])
c64.CHROUT(ubytearray[X])
c64.CHROUT(memubytearray[X])
c64.CHROUT(b1) ; @todo fix compiler crash incompatible data types
c64.CHROUT(mb1) ; @todo fix compiler crash incompatible data types
c64.CHROUT(bytearray[1]) ; @todo fix compiler crash incompatible data types
c64.CHROUT(membytearray[1]) ; @todo fix compiler crash incompatible data types
c64.CHROUT(wordarray[1]) ; @todo fix compiler crash incompatible data types
testsub(X) ; @todo fix compiler crash
testsub(b1) ; @todo fix compiler crash
testsub(ub1) ; @todo fix compiler crash
testsub(mb1) ; @todo fix compiler crash
testsub(mub1) ; @todo fix compiler crash
testsub(bytearray[1]) ; @todo fix compiler crash
testsub(ubytearray[1]) ; @todo fix compiler crash
testsub(membytearray[1]) ; @todo fix compiler crash
testsub(memubytearray[1]) ; @todo fix compiler crash
testsub(ubytearray[X]) ; @todo fix compiler crash
testsub(memubytearray[X]) ; @todo fix compiler crash
testsub(wordarray[1]) ; @todo fix compiler crash
testsub(X)
testsub(ub1)
testsub(mub1)
testsub(ubytearray[1])
testsub(memubytearray[1])
testsub(ubytearray[X])
testsub(memubytearray[X])
testsub(b1) ; @todo should give datatype error
testsub(mb1) ; @todo should give datatype error
testsub(bytearray[1]) ; @todo should give datatype error
testsub(membytearray[1]) ; @todo should give datatype error
testsub(wordarray[1]) ; @todo should give datatype error
return
}

8
compiler/src/prog8/ast/AstChecker.kt
View File

@ -707,9 +707,11 @@ class AstChecker(private val namespace: INameScope,
if(argDt!=null && !argDt.assignableTo(arg.second.type))
checkResult.add(ExpressionError("subroutine argument ${arg.first.index+1} has invalid type, expected ${arg.second.type}", position))
if(target.asmParameterRegisters[arg.first.index].registerOrPair in setOf(RegisterOrPair.AX, RegisterOrPair.XY, RegisterOrPair.X)) {
if(arg.first.value !is LiteralValue && arg.first.value !is IdentifierReference)
printWarning("calling a subroutine that expects X as a parameter is problematic, more so when providing complex arguments. If you see a compiler error/crash about this later, try to simplify this call", position)
if(target.isAsmSubroutine) {
if (target.asmParameterRegisters[arg.first.index].registerOrPair in setOf(RegisterOrPair.AX, RegisterOrPair.XY, RegisterOrPair.X)) {
if (arg.first.value !is LiteralValue && arg.first.value !is IdentifierReference)
printWarning("calling a subroutine that expects X as a parameter is problematic, more so when providing complex arguments. If you see a compiler error/crash about this later, try to simplify this call", position)
}
}
}
}

18
compiler/src/prog8/compiler/Compiler.kt
View File

@ -780,18 +780,18 @@ private class StatementTranslator(private val prog: IntermediateProgram,
when (arg.second.registerOrPair!!) {
A -> {
val assign = Assignment(listOf(AssignTarget(Register.A, null, null, callPosition)), null, arg.first, callPosition)
assign.linkParents(subroutine.parent)
assign.linkParents(arguments[0].parent)
translate(assign)
}
X -> {
// TODO: save X on stack & restore after call
val assign = Assignment(listOf(AssignTarget(Register.X, null, null, callPosition)), null, arg.first, callPosition)
assign.linkParents(subroutine.parent)
assign.linkParents(arguments[0].parent)
translate(assign)
}
Y -> {
val assign = Assignment(listOf(AssignTarget(Register.Y, null, null, callPosition)), null, arg.first, callPosition)
assign.linkParents(subroutine.parent)
assign.linkParents(arguments[0].parent)
translate(assign)
}
AX -> {
@ -804,8 +804,8 @@ private class StatementTranslator(private val prog: IntermediateProgram,
valueX=LiteralValue.optimalInteger(0, callPosition)
val assignA = Assignment(listOf(AssignTarget(Register.A, null, null, callPosition)), null, valueA, callPosition)
val assignX = Assignment(listOf(AssignTarget(Register.X, null, null, callPosition)), null, valueX, callPosition)
assignA.linkParents(subroutine.parent)
assignX.linkParents(subroutine.parent)
assignA.linkParents(arguments[0].parent)
assignX.linkParents(arguments[0].parent)
translate(assignA)
translate(assignX)
} else if(paramDt==DataType.UWORD) {
@ -823,8 +823,8 @@ private class StatementTranslator(private val prog: IntermediateProgram,
valueY=LiteralValue.optimalInteger(0, callPosition)
val assignA = Assignment(listOf(AssignTarget(Register.A, null, null, callPosition)), null, valueA, callPosition)
val assignY = Assignment(listOf(AssignTarget(Register.Y, null, null, callPosition)), null, valueY, callPosition)
assignA.linkParents(subroutine.parent)
assignY.linkParents(subroutine.parent)
assignA.linkParents(arguments[0].parent)
assignY.linkParents(arguments[0].parent)
translate(assignA)
translate(assignY)
} else if(paramDt==DataType.UWORD) {
@ -843,8 +843,8 @@ private class StatementTranslator(private val prog: IntermediateProgram,
valueY=LiteralValue.optimalInteger(0, callPosition)
val assignX = Assignment(listOf(AssignTarget(Register.X, null, null, callPosition)), null, valueX, callPosition)
val assignY = Assignment(listOf(AssignTarget(Register.Y, null, null, callPosition)), null, valueY, callPosition)
assignX.linkParents(subroutine.parent)
assignY.linkParents(subroutine.parent)
assignX.linkParents(arguments[0].parent)
assignY.linkParents(arguments[0].parent)
translate(assignX)
translate(assignY)
} else if(paramDt==DataType.UWORD) {