Apple-2-SW/prog8
1
0
Fork 0
mirror of https://github.com/irmen/prog8.git synced 2025-02-26 11:29:24 +00:00
Code Issues Projects Releases Wiki Activity

preparing for more optimizations

Browse Source
This commit is contained in:
Irmen de Jong 2021-11-12 23:23:51 +01:00
parent 75a06d2a40
commit 3483515346
2 changed files with 29 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
compiler/src/prog8/compiler/astprocessing/VariousCleanups.kt
View File

@ -74,18 +74,13 @@ internal class VariousCleanups(val program: Program, val errors: IErrorReporter)
if(sourceDt istype typecast.type) if(sourceDt istype typecast.type)
return listOf(IAstModification.ReplaceNode(typecast, typecast.expression, parent)) return listOf(IAstModification.ReplaceNode(typecast, typecast.expression, parent))
// TODO finish this; get rid of redundant final typecast to variable's type if they are the same if(parent is Assignment) {
// if(parent is Assignment) { val targetDt = (parent).target.inferType(program).getOrElse { throw FatalAstException("invalid dt") }
// val targetDt = (parent).target.inferType(program).getOrElse { throw FatalAstException("invalid dt") } if(sourceDt istype targetDt) {
// if(sourceDt istype targetDt) { // we can get rid of this typecast because the type is already
// // we can get rid of this typecast because the type is already return listOf(IAstModification.ReplaceNode(typecast, typecast.expression, parent))
// // TODO REMOVE IT }
// println("TYPECAST IN ASSIGNMENT $parent") // TODO DEBUG }
// } else {
// // TODO
// println("${typecast.expression} : source=$sourceDt to $targetDt")
// }
// }
return noModifications return noModifications
} }

24
compiler/test/TestOptimization.kt
View File

@ -14,6 +14,7 @@ import prog8.ast.base.Position
import prog8.ast.expressions.* import prog8.ast.expressions.*
import prog8.ast.statements.* import prog8.ast.statements.*
import prog8.compiler.BeforeAsmGenerationAstChanger import prog8.compiler.BeforeAsmGenerationAstChanger
import prog8.compiler.printAst
import prog8.compiler.target.C64Target import prog8.compiler.target.C64Target
import prog8.compilerinterface.* import prog8.compilerinterface.*
import prog8tests.helpers.DummyFunctions import prog8tests.helpers.DummyFunctions
@ -128,6 +129,27 @@ class TestOptimization: FunSpec({
(initY2.value as NumericLiteralValue).number.toDouble() shouldBe 11.0 (initY2.value as NumericLiteralValue).number.toDouble() shouldBe 11.0
} }
test("typecasted assignment from ubyte logical expressoin to uword var") {
val src = """
main {
sub start() {
ubyte bb
uword ww
ww = not bb or not ww ; expression combining ubyte and uword
}
}
"""
val result = compileText(C64Target, false, src, writeAssembly = false).assertSuccess()
// ww = ((( not bb as uword) or not ww) as uword)
val wwAssign = result.program.entrypoint.statements.last() as Assignment
val expr = wwAssign.value as TypecastExpression
wwAssign.target.identifier?.nameInSource shouldBe listOf("ww")
expr.type shouldBe DataType.UWORD
expr.expression.inferType(result.program).istype(DataType.UBYTE) shouldBe true
}
test("intermediate assignment steps have correct types for codegen phase (BeforeAsmGenerationAstChanger)") { test("intermediate assignment steps have correct types for codegen phase (BeforeAsmGenerationAstChanger)") {
val src = """ val src = """
main { main {
@ -168,8 +190,6 @@ class TestOptimization: FunSpec({
val assigns = result.program.entrypoint.statements.filterIsInstance<Assignment>() val assigns = result.program.entrypoint.statements.filterIsInstance<Assignment>()
val bbAssigns = assigns.filter { it.value !is NumericLiteralValue } val bbAssigns = assigns.filter { it.value !is NumericLiteralValue }
bbAssigns.size shouldBe 2 bbAssigns.size shouldBe 2
println(bbAssigns[0])
println(bbAssigns[1])
bbAssigns[0].target.identifier!!.nameInSource shouldBe listOf("bb") bbAssigns[0].target.identifier!!.nameInSource shouldBe listOf("bb")
bbAssigns[0].value shouldBe instanceOf<PrefixExpression>() bbAssigns[0].value shouldBe instanceOf<PrefixExpression>()