From 5ee36c897d2ef0965e860aa48683dca1a8976620 Mon Sep 17 00:00:00 2001 From: Irmen de Jong Date: Thu, 29 Apr 2021 00:52:14 +0200 Subject: [PATCH] todo --- compiler/res/prog8lib/cx16/gfx2.p8 | 2 +- compiler/src/prog8/compiler/BeforeAsmGenerationAstChanger.kt | 3 +-- docs/source/todo.rst | 2 -- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/compiler/res/prog8lib/cx16/gfx2.p8 b/compiler/res/prog8lib/cx16/gfx2.p8 index 9183e2cbc..4842a2f02 100644 --- a/compiler/res/prog8lib/cx16/gfx2.p8 +++ b/compiler/res/prog8lib/cx16/gfx2.p8 @@ -776,7 +776,7 @@ _done sub text(uword @zp x, uword y, ubyte color, uword sctextptr) { ; -- Write some text at the given pixel position. The text string must be in screencode encoding (not petscii!). ; You must also have called text_charset() first to select and prepare the character set to use. - ; NOTE: in monochrome (1bpp) screen modes, x position is currently constrained to mulitples of 8 ! TODO allow per-pixel horizontal positioning + ; NOTE: in monochrome (1bpp) screen modes, x position is currently constrained to multiples of 8 ! TODO allow per-pixel horizontal positioning uword chardataptr when active_mode { 1, 5 -> { diff --git a/compiler/src/prog8/compiler/BeforeAsmGenerationAstChanger.kt b/compiler/src/prog8/compiler/BeforeAsmGenerationAstChanger.kt index ec6915200..a3edf0162 100644 --- a/compiler/src/prog8/compiler/BeforeAsmGenerationAstChanger.kt +++ b/compiler/src/prog8/compiler/BeforeAsmGenerationAstChanger.kt @@ -82,8 +82,7 @@ internal class BeforeAsmGenerationAstChanger(val program: Program, val errors: I val sub = scope.definingSubroutine() if (sub != null) { - // move vardecls of the scope into the upper scope. Make sure the position remains the same! - // TODO THIS HAS ALREADY BEEN TAKEN CARE OF AT THE START???? + // move any remaining vardecls of the scope into the upper scope. Make sure the position remains the same! val replacements = mutableListOf() val movements = mutableListOf() diff --git a/docs/source/todo.rst b/docs/source/todo.rst index 42e9f395a..b1d278e3d 100644 --- a/docs/source/todo.rst +++ b/docs/source/todo.rst @@ -2,8 +2,6 @@ TODO ==== -- BeforeAsmGenerationAstChanger no longer needs to move vardecls?? - - simplify cx16.joystick_get2() once this cx16 rom issue is resolved: https://github.com/commanderx16/x16-rom/issues/203 - c64: make the graphics.BITMAP_ADDRESS configurable (VIC banking) - get rid of all other TODO's in the code ;-)