Apple-2-SW/prog8
1
0
Fork 0
mirror of https://github.com/irmen/prog8.git synced 2024-12-25 23:29:55 +00:00
Code Issues Projects Releases Wiki Activity

don't complain about uninitialized str var if it's not a var

Browse Source
This commit is contained in:
Irmen de Jong 2021-10-24 15:13:38 +02:00
parent 2815a14bb5
commit 6b32535cb6
3 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
compiler/src/prog8/compiler/astprocessing/AstChecker.kt
View File

@ -627,8 +627,12 @@ internal class AstChecker(private val program: Program,
} }
if(decl.datatype==DataType.STR) { if(decl.datatype==DataType.STR) {
if(decl.value==null) if(decl.value==null) {
// complain about uninitialized str, but only if it's a regular variable
val parameter = (decl.parent as? Subroutine)?.parameters?.singleOrNull{ it.name==decl.name }
if(parameter==null)
err("string var must be initialized with a string literal") err("string var must be initialized with a string literal")
}
else if (decl.type==VarDeclType.VAR && decl.value !is StringLiteralValue) else if (decl.type==VarDeclType.VAR && decl.value !is StringLiteralValue)
err("string var can only be initialized with a string literal") err("string var can only be initialized with a string literal")
} }

1
compiler/test/TestSubroutines.kt
View File

@ -36,7 +36,6 @@ class TestSubroutines {
val errors = ErrorReporterForTests() val errors = ErrorReporterForTests()
compileText(C64Target, false, text, errors, false).assertFailure("currently str type in signature is invalid") // TODO should not be invalid compileText(C64Target, false, text, errors, false).assertFailure("currently str type in signature is invalid") // TODO should not be invalid
assertEquals(0, errors.warnings.size) assertEquals(0, errors.warnings.size)
// TODO fix extra error "string var must be initialized with a string literal"
assertTrue(errors.errors.single().startsWith("Pass-by-reference types (str, array) cannot occur as a parameter type directly.")) assertTrue(errors.errors.single().startsWith("Pass-by-reference types (str, array) cannot occur as a parameter type directly."))
} }

1
examples/test.p8
View File

@ -1,5 +1,6 @@
main { main {
sub start() { sub start() {
str zzz
asmfunc("text") asmfunc("text")
func("text") func("text")
} }