Apple-2-SW/prog8
1
0
Fork 0
mirror of https://github.com/irmen/prog8.git synced 2025-08-09 19:25:22 +00:00
Code Issues Projects Releases Wiki Activity

rollback binexpr splitting, caused slowdowns

Browse Source
This commit is contained in:
Irmen de Jong
2021-11-28 18:50:05 +01:00
parent 32068a832a
commit 9256f910f0
1 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
codeOptimizers/src/prog8/optimizer/BinExprSplitter.kt
View File

@@ -58,19 +58,19 @@ X = BinExpr X = LeftExpr
if(rightBx!=null && (!rightBx.left.isSimple || !rightBx.right.isSimple)) if(rightBx!=null && (!rightBx.left.isSimple || !rightBx.right.isSimple))
return noModifications return noModifications
// TODO below attempts to remove stack-based evaluated expressions, but sometimes the resulting code is BIGGER. // TODO below attempts to remove stack-based evaluated expressions, but often the resulting code is BIGGER, and SLOWER.
val dt = assignment.target.inferType(program) // val dt = assignment.target.inferType(program)
if(!dt.isInteger) // if(!dt.isInteger)
return noModifications // return noModifications
val tempVar = IdentifierReference(getTempVarName(dt), binExpr.right.position) // val tempVar = IdentifierReference(getTempVarName(dt), binExpr.right.position)
val assignTempVar = Assignment( // val assignTempVar = Assignment(
AssignTarget(tempVar, null, null, binExpr.right.position), // AssignTarget(tempVar, null, null, binExpr.right.position),
binExpr.right, binExpr.right.position // binExpr.right, binExpr.right.position
) // )
return listOf( // return listOf(
IAstModification.InsertBefore(assignment, assignTempVar, assignment.parent as IStatementContainer), // IAstModification.InsertBefore(assignment, assignTempVar, assignment.parent as IStatementContainer),
IAstModification.ReplaceNode(binExpr.right, tempVar.copy(), binExpr) // IAstModification.ReplaceNode(binExpr.right, tempVar.copy(), binExpr)
) // )
} }
if(binExpr.right.isSimple) { if(binExpr.right.isSimple) {