Apple-2-SW/prog8
1
0
Fork 0
mirror of https://github.com/irmen/prog8.git synced 2024-12-26 14:29:35 +00:00
Code Issues Projects Releases Wiki Activity

check for non-executed statements in main block

Browse Source
This commit is contained in:
Irmen de Jong 2018-12-19 03:04:27 +01:00
parent c1204b83bd
commit d305a44557
2 changed files with 21 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
compiler/examples/test.p8
View File

@ -4,12 +4,10 @@
~ main { ~ main {
c64.TIME_HI=1 ; @todo WARNING about 'free' statements in main
c64.TIME_MID=0
c64.TIME_LO=0
;c64scr.PLOT(screenx(x), screeny(y)) ; @todo fix argument calculation???!!! ;c64scr.PLOT(screenx(x), screeny(y)) ; @todo fix argument calculation???!!!
; @todo unify the type cast functions... "wrd(5)" -> "5 as word"
sub toscreenx(float x, float z) -> word { sub toscreenx(float x, float z) -> word {
return 42 return 42
} }

19
compiler/src/prog8/ast/AstChecker.kt
View File

@ -80,6 +80,25 @@ class AstChecker(private val namespace: INameScope,
checkResult.add(SyntaxError("program entrypoint subroutine can't have parameters and/or return values", startSub.position)) checkResult.add(SyntaxError("program entrypoint subroutine can't have parameters and/or return values", startSub.position))
} }
if(mainBlock!=null) {
// the main module cannot contain 'regular' statements (they will never be executed!)
for (statement in mainBlock.statements) {
val ok = when(statement) {
is Block->true
is Directive->true
is Label->true
is VarDecl->true
is InlineAssembly->true
is INameScope->true
else->false
}
if(!ok) {
checkResult.add(SyntaxError("main block contains regular statements, this is not allowed (they'll never get executed). Use subroutines.", statement.position))
break
}
}
}
// there can be an optional 'irq' block with a 'irq' subroutine in it, // there can be an optional 'irq' block with a 'irq' subroutine in it,
// which will be used as the 60hz irq routine in the vm if it's present. // which will be used as the 60hz irq routine in the vm if it's present.
val irqBlock = module.statements.singleOrNull { it is Block && it.name=="irq" } as? Block? val irqBlock = module.statements.singleOrNull { it is Block && it.name=="irq" } as? Block?