Apple-2-SW/prog8
1
0
Fork 0
mirror of https://github.com/irmen/prog8.git synced 2025-01-14 01:29:55 +00:00
Code Issues Projects Releases Wiki Activity

added error message when not using returnvalue of a functioncall

Browse Source
This commit is contained in:
Irmen de Jong 2020-12-27 02:28:40 +01:00
parent b40e1eabb9
commit d7d7147d43
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
compiler/src/prog8/ast/processing/AstChecker.kt
View File

@ -11,6 +11,7 @@ import prog8.compiler.target.C64Target
import prog8.compiler.target.CompilationTarget import prog8.compiler.target.CompilationTarget
import prog8.compiler.target.Cx16Target import prog8.compiler.target.Cx16Target
import prog8.functions.BuiltinFunctions import prog8.functions.BuiltinFunctions
import prog8.functions.builtinFunctionReturnType
import java.io.File import java.io.File
internal class AstChecker(private val program: Program, internal class AstChecker(private val program: Program,
@ -972,6 +973,11 @@ internal class AstChecker(private val program: Program,
else else
errors.warn("result values of subroutine call are discarded (use void?)", functionCallStatement.position) errors.warn("result values of subroutine call are discarded (use void?)", functionCallStatement.position)
} }
else if(targetStatement is BuiltinFunctionStatementPlaceholder) {
val rt = builtinFunctionReturnType(targetStatement.name, functionCallStatement.args, program)
if(rt.isKnown)
errors.warn("result value of a function call is discarded (use void?)", functionCallStatement.position)
}
} }
if(functionCallStatement.target.nameInSource.last() == "sort") { if(functionCallStatement.target.nameInSource.last() == "sort") {

2
compiler/src/prog8/functions/BuiltinFunctions.kt
View File

@ -145,9 +145,9 @@ private val functionSignatures: List<FSignature> = listOf(
FSignature("clear_irqd" , false, emptyList(), null), FSignature("clear_irqd" , false, emptyList(), null),
FSignature("read_flags" , true, emptyList(), DataType.UBYTE), FSignature("read_flags" , true, emptyList(), DataType.UBYTE),
FSignature("progend" , true, emptyList(), DataType.UWORD), FSignature("progend" , true, emptyList(), DataType.UWORD),
FSignature("memory" , true, listOf(FParam("name", setOf(DataType.STR)), FParam("size", setOf(DataType.UWORD))), DataType.UWORD),
FSignature("target" , true, emptyList(), DataType.UBYTE, ::builtinTarget), FSignature("target" , true, emptyList(), DataType.UBYTE, ::builtinTarget),
FSignature("swap" , false, listOf(FParam("first", NumericDatatypes), FParam("second", NumericDatatypes)), null), FSignature("swap" , false, listOf(FParam("first", NumericDatatypes), FParam("second", NumericDatatypes)), null),
FSignature("memory" , false, listOf(FParam("name", setOf(DataType.STR)), FParam("size", setOf(DataType.UWORD))), DataType.UWORD),
FSignature("memcopy" , false, listOf( FSignature("memcopy" , false, listOf(
FParam("from", IterableDatatypes + DataType.UWORD), FParam("from", IterableDatatypes + DataType.UWORD),
FParam("to", IterableDatatypes + DataType.UWORD), FParam("to", IterableDatatypes + DataType.UWORD),