Apple-2-Tools/AppleWin
1
0
Fork 0
mirror of https://github.com/AppleWin/AppleWin.git synced 2024-12-29 08:30:04 +00:00
Code Issues Projects Releases Wiki Activity

Avoid sign extension issues in 64 bit. (PR #1112)

Browse Source 
If "GetVideo().GetFrameBufferCentringValue() - kOverscanOffsetL" is negative, it causes an overflow.
This commit is contained in:
Andrea 2022-06-07 22:00:33 +02:00 committed by GitHub
parent 061570398d
commit 3d260e8b78
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
source/NTSC.cpp
View File

@ -813,15 +813,15 @@ static void ClearOverscanVideoArea(void)
uint32_t* pLine1Prev = getScanlinePreviousInbetween();
g_pVideoAddress = pSaveVideoAddress; // restore g_pVideoAddress
const uint32_t kOverscanOffsetL = 3; // In updateVideoScannerAddress(), g_pVideoAddress could be adjusted by: -2 + -1 = -3
const uint32_t kOverscanSpanL = 3;
const uint32_t kOverscanOverlapL = kOverscanSpanL - kOverscanOffsetL;
const int kOverscanOffsetL = 3; // In updateVideoScannerAddress(), g_pVideoAddress could be adjusted by: -2 + -1 = -3
const int kOverscanSpanL = 3;
const int kOverscanOverlapL = kOverscanSpanL - kOverscanOffsetL;
const uint32_t kOverscanOffsetR = 2;
const uint32_t kOverscanSpanR = 4; // In updateVideoScannerHorzEOL() it writes 4 extra pixels
const uint32_t kOverscanOverlapR = kOverscanSpanR - kOverscanOffsetR;
const int kOverscanOffsetR = 2;
const int kOverscanSpanR = 4; // In updateVideoScannerHorzEOL() it writes 4 extra pixels
const int kOverscanOverlapR = kOverscanSpanR - kOverscanOffsetR;
const uint32_t kHorzPixels = (VIDEO_SCANNER_MAX_HORZ - VIDEO_SCANNER_HORZ_START) * 14;
const int kHorzPixels = (VIDEO_SCANNER_MAX_HORZ - VIDEO_SCANNER_HORZ_START) * 14;
pLine1Prev += GetVideo().GetFrameBufferCentringValue() - kOverscanOffsetL; // Centre the older //e video modes when running with a VidHD