Apple-2-Tools/AppleWin
1
0
Fork 0
mirror of https://github.com/AppleWin/AppleWin.git synced 2024-06-14 08:29:34 +00:00
Code Issues Projects Releases Wiki Activity

Add constructor for SY6522_AY8910 for correct initialisation (PR #940)

Browse Source 
Avoid leaks when the destructor of SY6522_AY8910 is not called.
This commit is contained in:
Andrea 2021-04-05 17:44:59 +01:00 committed by GitHub
parent 7a41ede6d9
commit a37d0b078f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
source/Mockingboard.cpp
View File

@ -131,6 +131,20 @@ struct SY6522_AY8910
SSI263 ssi263;
MockingboardUnitState_e state; // Where a unit is a 6522+AY8910 pair
MockingboardUnitState_e stateB; // Phasor: 6522 & 2nd AY8910
// SSI263 has a constructor, and so SY6522_AY8910 needs one too
// memset(0) is not guaranteed to work
SY6522_AY8910(void)
{
memset(&sy6522, 0, sizeof(sy6522));
nAY8910Number = 0;
nAYCurrentRegister = 0;
bTimer1Active = false;
bTimer2Active = false;
state = AY_NOP0;
stateB = AY_NOP0;
// ssi263 has already been default constructed
}
};
@ -1104,8 +1118,6 @@ void MB_Initialize()
}
else
{
memset(&g_MB,0,sizeof(g_MB));
for (UINT i=0; i<NUM_VOICES; i++)
ppAYVoiceBuffer[i] = new short [SAMPLE_RATE]; // Buffer can hold a max of 1 seconds worth of samples
@ -1114,6 +1126,7 @@ void MB_Initialize()
for (UINT i=0; i<NUM_AY8910; i++)
{
g_MB[i] = SY6522_AY8910();
g_MB[i].nAY8910Number = i;
g_MB[i].ssi263.SetDevice(i);
}