From c022bbde72ed3c3d2c883d745cae6db8d224f390 Mon Sep 17 00:00:00 2001 From: tomcw Date: Sat, 13 Jan 2024 12:48:21 +0000 Subject: [PATCH] Load save-state: Remove superfluous call to UpdatePaging() in MemLoadSnapshot(). (#1267) --- source/Memory.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/source/Memory.cpp b/source/Memory.cpp index 854fa45c..49ea63ff 100644 --- a/source/Memory.cpp +++ b/source/Memory.cpp @@ -2360,11 +2360,8 @@ bool MemLoadSnapshot(YamlLoadHelper& yamlLoadHelper, UINT unitVersion) yamlLoadHelper.PopMap(); - // - - // NB. MemUpdatePaging(TRUE) called at end of Snapshot_LoadState_v2() - UpdatePaging(1); // Initialize=1 (Still needed, even with call to MemUpdatePaging() - why?) - // TC-TODO: At this point, the cards haven't been loaded, so the card's expansion ROM is unknown - so pointless(?) calling this now + // NB. MemInitializeFromSnapshot()->MemUpdatePaging() called at end of Snapshot_LoadState_v2() + // . At this point, the cards haven't been loaded (no aux mem & any card's expansion ROM is unknown) - so pointless calling MemUpdatePaging() at this stage (GH#1267) return true; }