Apple-2-Tools/apple2ix
1
0
Fork 0
mirror of https://github.com/mauiaaron/apple2.git synced 2024-06-26 00:29:27 +00:00
Code Issues Projects Releases Wiki Activity

Avoid UI race when copying assets to storage

Browse Source
This commit is contained in:
Aaron Culliney 2019-11-29 14:03:09 -08:00
parent 296bd12029
commit 68e6fb768f
1 changed files with 56 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
Android/app/src/main/java/org/deadc0de/apple2ix/Apple2Utils.java
View File

@ -14,6 +14,7 @@ package org.deadc0de.apple2ix;
import android.content.pm.PackageInfo; import android.content.pm.PackageInfo;
import android.content.pm.PackageManager; import android.content.pm.PackageManager;
import android.content.res.AssetManager; import android.content.res.AssetManager;
import android.os.AsyncTask;
import android.os.Environment; import android.os.Environment;
import android.util.Log; import android.util.Log;
import android.view.View; import android.view.View;
@ -318,7 +319,7 @@ public class Apple2Utils {
return sDataDir; return sDataDir;
} }
public static void exposeAPKAssetsToExternal(Apple2Activity activity) { public static void exposeAPKAssetsToExternal(final Apple2Activity activity) {
getExternalStorageDirectory(activity); getExternalStorageDirectory(activity);
if (sExternalFilesDir == null) { if (sExternalFilesDir == null) {
return; return;
@ -331,12 +332,10 @@ public class Apple2Utils {
try { try {
bar.setVisibility(View.VISIBLE); bar.setVisibility(View.VISIBLE);
bar.setIndeterminate(true); bar.setIndeterminate(true);
} catch (NullPointerException npe) {
Log.v(TAG, "Avoid NPE in exposeAPKAssetsToExternal #1");
}
}
});
AsyncTask.execute(new Runnable() {
@Override
public void run() {
Log.v(TAG, "Overwriting system files in /sdcard/apple2ix/ (external storage) ..."); Log.v(TAG, "Overwriting system files in /sdcard/apple2ix/ (external storage) ...");
recursivelyCopyAPKAssets(activity, /*from APK directory:*/"keyboards", /*to location:*/sExternalFilesDir.getAbsolutePath(), false); recursivelyCopyAPKAssets(activity, /*from APK directory:*/"keyboards", /*to location:*/sExternalFilesDir.getAbsolutePath(), false);
@ -352,8 +351,15 @@ public class Apple2Utils {
} }
}); });
} }
});
} catch (NullPointerException npe) {
Log.v(TAG, "Avoid NPE in exposeAPKAssetsToExternal #1");
}
}
});
}
public static void exposeAPKAssets(Apple2Activity activity) { public static void exposeAPKAssets(final Apple2Activity activity) {
final ProgressBar bar = (ProgressBar) activity.findViewById(R.id.crash_progressBar); final ProgressBar bar = (ProgressBar) activity.findViewById(R.id.crash_progressBar);
activity.runOnUiThread(new Runnable() { activity.runOnUiThread(new Runnable() {
@Override @Override
@ -361,12 +367,10 @@ public class Apple2Utils {
try { try {
bar.setVisibility(View.VISIBLE); bar.setVisibility(View.VISIBLE);
bar.setIndeterminate(true); bar.setIndeterminate(true);
} catch (NullPointerException npe) {
Log.v(TAG, "Avoid NPE in exposeAPKAssets #1");
}
}
});
AsyncTask.execute(new Runnable() {
@Override
public void run() {
getDataDir(activity); getDataDir(activity);
// FIXME TODO : Heavy-handed migration to 1.1.3 ... // FIXME TODO : Heavy-handed migration to 1.1.3 ...
@ -395,6 +399,14 @@ public class Apple2Utils {
} }
}); });
} }
});
} catch (NullPointerException npe) {
Log.v(TAG, "Avoid NPE in exposeAPKAssets #1");
}
}
});
}
public static void exposeSymbols(Apple2Activity activity) { public static void exposeSymbols(Apple2Activity activity) {
recursivelyCopyAPKAssets(activity, /*from APK directory:*/"symbols", /*to location:*/new File(sDataDir, "symbols").getAbsolutePath(), false); recursivelyCopyAPKAssets(activity, /*from APK directory:*/"symbols", /*to location:*/new File(sDataDir, "symbols").getAbsolutePath(), false);