Apple-2-Tools/apple2ix
1
0
Fork 0
mirror of https://github.com/mauiaaron/apple2.git synced 2024-11-19 11:31:13 +00:00
Code Issues Projects Releases Wiki Activity

Better comment for the current serious deficiency

Browse Source
This commit is contained in:
Aaron Culliney 2015-09-03 22:23:06 -07:00
parent 54587d166d
commit 8ffdb8461a
1 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/video/gltouchjoy_kpad.c
View File

@ -116,20 +116,14 @@ static inline void _touch_sourceBegin(volatile int *source) {
static void touchkpad_keyboardReadCallback(void) { static void touchkpad_keyboardReadCallback(void) {
assert(pthread_self() == cpu_thread_id); assert(pthread_self() == cpu_thread_id);
// HACK: filter out a certain number of callbacks to be assured that emulated software is actually ready for a new // HACK FIXME TODO :
// key.
// * J---- appears to work best everytime
// * S---B----- works better every other time (otherwise it misses flip-flop values)
// * DOS3.3 AppleSoft BASIC shell appears to need a much larger value ...
////static unsigned int callbackCounter = 0;
////++callbackCounter;
////if ((callbackCounter % kpad.callbackIgnoreThreshold) != 0) {
//// return;
////}
// //
// Arguably the proper fix HERE to understand the Apple //e keyboard hardware itself and what the maximum rate allowed // There are a number of cases where the emulated software is reading the keyboard state but not using the value.
// for changing keys. Then this callback would be called by the underlying VM at that rate (by perform the // This is quite noticeable in a number of games that take keyboard input.
// appropriate machine cycle counting -- same as for joystick handling) //
// This indicates that we are incorrectly emulating the keyboard hardware. The proper fix for this touch keypad
// joystick will be to properly emulate the original hardware timing, using the existing facility to count 65c02 CPU
// machine cyles.
#warning FIXME TODO : implement proper keyboard repeat callback timing #warning FIXME TODO : implement proper keyboard repeat callback timing
if (kpad.lastScancode >= 0) { if (kpad.lastScancode >= 0) {