mirror of
https://github.com/sheumann/hush.git
synced 2024-12-28 22:30:05 +00:00
builtin_read: note about better implementation
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
parent
03dad22f8a
commit
03d81ef43a
@ -20,6 +20,11 @@
|
||||
#include "shell_common.h"
|
||||
#include "builtin_read.h"
|
||||
|
||||
//TODO: use more efficient setvar() which takes a pointer to malloced "VAR=VAL"
|
||||
//string. hush naturally has it, and ash has setvareq().
|
||||
//Here we can simply store "VAR=" at buffer start and store read data directly
|
||||
//after "=", then pass buffer to setvar() to consume.
|
||||
|
||||
const char* FAST_FUNC
|
||||
shell_builtin_read(void FAST_FUNC (*setvar)(const char *name, const char *val),
|
||||
char **argv,
|
||||
|
Loading…
Reference in New Issue
Block a user