Apple-2gs-SW/hush
1
0
Fork 0
mirror of https://github.com/sheumann/hush.git synced 2024-11-19 08:31:11 +00:00
Code Issues Projects Releases Wiki Activity

cp: revert a recent buggy change, and add a comment why it's wrong

Browse Source 
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
This commit is contained in:
Denys Vlasenko 2009-10-08 01:32:44 +02:00
parent d427689eee
commit d5fddcd57f
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
coreutils/cp.c
View File

@ -182,10 +182,12 @@ int cp_main(int argc, char **argv)
if (copy_file(*argv, dest, flags) < 0) { if (copy_file(*argv, dest, flags) < 0) {
status = EXIT_FAILURE; status = EXIT_FAILURE;
} }
free((void*)dest);
if (*++argv == last) { if (*++argv == last) {
/* possibly leaking dest... */
break; break;
} }
/* don't move up: dest may be == last and not malloced! */
free((void*)dest);
} }
/* Exit. We are NOEXEC, not NOFORK. We do exit at the end of main() */ /* Exit. We are NOEXEC, not NOFORK. We do exit at the end of main() */