mirror of
https://github.com/sheumann/hush.git
synced 2024-12-27 01:32:08 +00:00
16767e2377
have checked in. Vladimir writes: Your patch have many problem. 1. You always added + time(). This cannot reset RANDOM=value for debuging with replay sequential. 2. Hmm. I examine bash 2.04 source. This pseudorandom generator use low bits of counter value. You use high bits. This make bad pseudorandom values after have 0-value. For example, if + time() do remove, your generator always return 0 after first generate 0. 3. Memory leak per call. Use ash-unlike unecessary bb_strdup function. 4. Unsupport show last $RANDOM value for "set" and "export" command. 5. Bloat code. Busybox-unlike patch - added unstandart feature as default hardcode. Last patch attached. Erik, why you apply Paul patch with have 5-th point problem? :( Last patch have ash change xwrite() to fresh libbb/bb_full_write interfase (haved loop after EINTR). --w vodz |
||
---|---|---|
.. | ||
ash.c | ||
cmdedit.c | ||
cmdedit.h | ||
Config.in | ||
hush.c | ||
lash.c | ||
Makefile | ||
Makefile.in | ||
msh.c |