Eric Andersen 3f47c453da Christian Grigis, christian.grigis at smartdata dot ch writes: ... Hello everyone, Busybox's insmod fails to locate a module when that module is the only one existing in the /lib/modules directory (with a unique name). Example: # find /lib/modules/ -type f /lib/modules/kernel/drivers/char/bios.o # insmod bios insmod: bios.o: no module by that name found # touch /lib/modules/dummy # find /lib/modules/ -type f /lib/modules/kernel/drivers/char/bios.o /lib/modules/dummy # insmod bios Using /lib/modules/kernel/drivers/char/bios.o As long as there is another file in the /lib/modules directory, insmod finds it OK. I tracked the problem down to 'check_module_name_match()' in insmod.c: It returns TRUE when a match is found, and FALSE otherwise. In the case where there is only one module in the /lib/modules directory (or more that one module, but all with the same name), 'recursive_action()' will return TRUE and we end up on line 4196 in 'insmod.c' which returns an error. [The reason it works with more than one module with different names is that in this case there will always be one not matching, 'recursive_action()' will return FALSE and we end up in line 4189.] Now, from the implementation of 'recursive_action()' and from other usages of it (tar.c, etc.), it seems to me that FALSE should be returned to indicate that we want to stop the recursion, so TRUE and FALSE should be inverted in 'check_module_name_match()'. At the same time, 'recursive_action()' continues to recurse even after the recursive call has returned FALSE; again in my understanding and other usages of it, we can safely stop recursing at this point. Here is my patch against 1.00-pre8:		2004-04-06 11:56:26 +00:00
..
Config.in	Remove trailing whitespace. Update copyright to include 2004.	2004-03-15 08:29:22 +00:00
insmod.c	Christian Grigis, christian.grigis at smartdata dot ch writes:	2004-04-06 11:56:26 +00:00
lsmod.c	Remove trailing whitespace. Update copyright to include 2004.	2004-03-15 08:29:22 +00:00
Makefile	Remove trailing whitespace. Update copyright to include 2004.	2004-03-15 08:29:22 +00:00
Makefile.in	Remove trailing whitespace. Update copyright to include 2004.	2004-03-15 08:29:22 +00:00
modprobe.c	whitespace cleanup	2004-01-10 11:29:31 +00:00
rmmod.c	As noted in a patch from Kendrick Hamilton, rmmod was only	2004-03-19 21:00:03 +00:00