mac-rom-simm-programmer/hal/at90usb646/spi.c
Doug Brown 7425af761a Break out code into a HAL, optimize flash operations
This makes the code pretty easily portable to other architectures if someone
wants to make a more modern SIMM programmer. I also was pretty careful to split
responsibilities of the different components and give the existing components
better names. I'm pretty happy with the organization of the code now.

As part of this change I have also heavily optimized the code. In particular,
the read and write cycle routines are very important to the overall performance
of the programmer. In these routines I had to make some tradeoffs of code
performance versus prettiness, but the overall result is much faster
programming.

Some of these performance changes are the result of what I discovered when
I upgraded my AVR compiler. I discovered that it is smarter at looking at 32-bit
variables when I use a union instead of bitwise operations.

I also shaved off more CPU cycles by carefully making a few small tweaks. I
added a bypass for the "program only some chips" mask, because it was adding
unnecessary CPU cycles for a feature that is rarely used. I removed the
verification feature from the write routine, because we can always verify the
data after the write chunk is complete, which is more efficient. I also added
assumptions about the initial/final state of the CS/OE/WE pins, which allowed me
to remove more valuable CPU cycles from the read/write cycle routines.

There are also a few enormous performance optimizations I should have done a
long time ago:

1) The code was only handling one received byte per main loop iteration. Reading
   every byte available cut nearly a minute off of the 8 MB programming time.
2) The code wasn't taking advantage of the faster programming command available
   in the chips used on the 8 MB SIMM.

The end result of all of these optimizations is I have programming time of the
8 MB SIMM down to 3:31 (it used to be 8:43).

Another minor issue I fixed: the Micron SIMM chip identification wasn't working
properly. It was outputting the manufacturer ID again instead of the device ID.
2020-11-27 00:16:35 -08:00

171 lines
4.0 KiB
C

/*
* spi.c
*
* Created on: Nov 14, 2020
* Author: Doug
*/
#include "../spi.h"
#include "gpio_hw.h"
#include <stddef.h>
#include <avr/io.h>
/// Keep a struct of available dividers, calculate something at runtime.
typedef struct SPIDividerInfo
{
/// The divider
uint8_t divider;
/// Bit 0 = SPR0, Bit 1 = SPR1, Bit 2 = SPI2X (in SPSR)
uint8_t configBits;
} SPIDividerInfo;
/// List of possible SPI dividers. Must be in ascending order.
static const SPIDividerInfo dividers[] = {
{2, 0b100},
{4, 0b000},
{8, 0b101},
{16, 0b001},
{32, 0b110},
{64, 0b010},
{128, 0b011}
};
/// The lone SPI controller available on this AVR
static SPIController controller =
{
.sckPin = {GPIOB, 1},
.mosiPin = {GPIOB, 2},
.misoPin = {GPIOB, 3}
};
/** Gets the SPI hardware controller at the specified index
*
* @param index The index of the controller. Only 0 is valid on this AVR.
* @return The SPI controller, or NULL if an invalid index is supplied
*/
SPIController *SPI_Controller(uint8_t index)
{
// The AVR only has one SPI controller
return (index == 0) ? &controller : NULL;
}
/** Initializes the supplied SPI controller
*
* @param c The controller
*/
void SPI_InitController(SPIController *c)
{
GPIO_SetDirection(c->sckPin, true);
GPIO_SetDirection(c->mosiPin, true);
GPIO_SetDirection(c->misoPin, false);
// Don't do anything with the rest of the registers.
// SPI_RequestController will handle it.
}
/** Initializes the supplied SPI device
*
* @param spi The device
* @param maxClock The maximum clock rate supported by the device in Hz
* @param mode The SPI mode (see the SPI_MODE_*, SPI_CPHA, and SPI_CPOL defines)
* @return True on success, false on failure
*/
bool SPI_InitDevice(SPIDevice *spi, uint32_t maxClock, uint8_t mode)
{
GPIO_SetDirection(spi->csPin, true);
SPI_Deassert(spi);
// Calculate which SPI clock divider to use
int8_t dividerIndex = -1;
for (uint8_t i = 0; dividerIndex < 0 && i < sizeof(dividers)/sizeof(dividers[0]); i++)
{
if (F_CPU / (uint32_t)dividers[i].divider <= maxClock)
{
dividerIndex = (int8_t)i;
}
}
// Fill in the SPI config registers according to the requested clock
if (dividerIndex >= 0)
{
uint8_t dividerBits = dividers[dividerIndex].configBits;
spi->private.spcr =
(0 << SPIE) | // No SPI interrupts
(1 << SPE) | // Enable SPI
(0 << DORD) | // MSB first
(1 << MSTR) | // Master mode
(((mode & SPI_CPOL) ? 1 : 0) << CPOL) |
(((mode & SPI_CPHA) ? 1 : 0) << CPHA) |
((dividerBits & 3) << SPR0);
// The only writable bit in SPSR is the SPI2X bit.
spi->private.spsr =
((dividerBits >> 2) << SPI2X);
return true;
}
else
{
// This SPI device requires a clock slower than what we can divide down to
return true;
}
}
/** Allows an SPI device to request control of the bus.
*
* @param spi The SPI device
*/
void SPI_RequestBus(SPIDevice *spi)
{
(void)spi;
// Set up the controller with the correct speed/mode config for this device
SPCR = spi->private.spcr;
SPSR = spi->private.spsr;
}
/** Allows an SPI device to relinquish control of the bus.
*
* @param spi The SPI device
*/
void SPI_ReleaseBus(SPIDevice *spi)
{
(void)spi;
}
/** Asserts an SPI device's chip select pin
*
* @param spi The SPI device
*/
void SPI_Assert(SPIDevice *spi)
{
GPIO_SetOff(spi->csPin);
}
/** Deasserts an SPI device's chip select pin
*
* @param spi The SPI device
*/
void SPI_Deassert(SPIDevice *spi)
{
GPIO_SetOn(spi->csPin);
}
/** Transfers a single byte to/from an SPI device
*
* @param spi The SPI device
* @param b The byte to send
* @return The byte that was simultaneously received
*/
uint8_t SPI_RWByte(SPIDevice *spi, uint8_t b)
{
// Since there's only one controller on this AVR, we don't actually care
// about the SPI device pointer here
(void)spi;
// Write the byte, wait for the write to complete, read back the result
SPDR = b;
while (!(SPSR & (1 << SPIF)));
return SPDR;
}