Macintosh-Tools/Retro68
1
0
Fork 0
mirror of https://github.com/autc04/Retro68.git synced 2025-01-12 10:31:01 +00:00
Code Issues Projects Releases Wiki Activity

remove the 'half-understood hack' added to fixup_args_size_notes years ago; it seems to cause ICEs.

Browse Source 
(see #232, #244, #167)
This commit is contained in:
Wolfgang Thaller 2024-05-11 02:25:05 +02:00
parent 2a15e6f1f3
commit 353b9713b1
1 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
gcc/gcc/expr.cc
View File

@ -4469,19 +4469,6 @@ fixup_args_size_notes (rtx_insn *prev, rtx_insn *last,
gcc_assert (!note || known_eq (args_size, get_args_size (note))); gcc_assert (!note || known_eq (args_size, get_args_size (note)));
poly_int64 this_delta = find_args_size_adjust (insn); poly_int64 this_delta = find_args_size_adjust (insn);
/* **** HALF-UNDERSTOOD HACK:
The original code here leaves out REG_ARGS_SIZE annotations for
instructions that don't adjust the stack under some circumstances.
In some situations, involving both m68k mac pascal functions
and exception handling, this leads to a failure in dwarf2cfi.c:combine_traces.
Disabling the if (this_delta == 0) fixes this, but causes the subsequent gcc_assert
to trip sometimes. Disabling both hasn't caused any observable problems... YET.
if (known_eq (this_delta, 0)) if (known_eq (this_delta, 0))
{ {
if (!CALL_P (insn) if (!CALL_P (insn)
@ -4491,8 +4478,6 @@ fixup_args_size_notes (rtx_insn *prev, rtx_insn *last,
} }
gcc_assert (!saw_unknown); gcc_assert (!saw_unknown);
*/
if (known_eq (this_delta, HOST_WIDE_INT_MIN)) if (known_eq (this_delta, HOST_WIDE_INT_MIN))
saw_unknown = true; saw_unknown = true;