From 73f04ef2d2e0fb9363ce10f47a3bcfca37692eb5 Mon Sep 17 00:00:00 2001 From: Andy McFadden Date: Sun, 27 Oct 2019 21:29:44 -0700 Subject: [PATCH] Update comments, remove unused var --- SourceGen/MainController.cs | 3 +++ SourceGen/PlatformSymbols.cs | 2 +- SourceGen/WpfGui/EditDefSymbol.xaml.cs | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/SourceGen/MainController.cs b/SourceGen/MainController.cs index a93bcbb..1ad33cb 100644 --- a/SourceGen/MainController.cs +++ b/SourceGen/MainController.cs @@ -1643,6 +1643,9 @@ namespace SourceGen { // the undo operation. Debug.WriteLine("EditAddress: not allowed to remove address at offset +000000"); } else if (true || attr.Address != dlg.Address) { + // NOTE: we used to prevent creation of an apparently redundant address change, + // but it's really helpful to put one on code that isn't moving before you + // start moving other stuff around. Debug.WriteLine("EditAddress: changing addr at offset +" + offset.ToString("x6") + " to " + dlg.Address); diff --git a/SourceGen/PlatformSymbols.cs b/SourceGen/PlatformSymbols.cs index 86947af..897e816 100644 --- a/SourceGen/PlatformSymbols.cs +++ b/SourceGen/PlatformSymbols.cs @@ -38,7 +38,7 @@ namespace SourceGen { /// Alphanumeric ASCII + underscore for label, which must start at beginning of line. /// Value is somewhat arbitrary, but ends if we see a comment delimiter (semicolon) or /// whitespace. Spaces are allowed between tokens, but not required. Value, width, - /// and mask may be hex, decimal, or binary. + /// and mask may be hex, decimal, or binary; these are simply tokenized by regex. /// /// Looks like: /// NAME {@,=,<,>} VALUE [& MASK] [WIDTH] [;COMMENT] diff --git a/SourceGen/WpfGui/EditDefSymbol.xaml.cs b/SourceGen/WpfGui/EditDefSymbol.xaml.cs index b74a8be..2f1bbdb 100644 --- a/SourceGen/WpfGui/EditDefSymbol.xaml.cs +++ b/SourceGen/WpfGui/EditDefSymbol.xaml.cs @@ -190,7 +190,7 @@ namespace SourceGen.WpfGui { Label = Value = VarWidth = Comment = string.Empty; - int maxWidth, maxAddr; + int maxWidth; if (isVariable) { ConstantLabel = (string)FindResource("str_VariableConstant"); maxWidth = 256;