6502/6502bench
1
0
Fork 0
mirror of https://github.com/fadden/6502bench.git synced 2025-07-25 14:24:13 +00:00
Code Issues Projects Releases Wiki Activity

Fix web site menu button

Browse Source 
A bit of Javascript was used to remove the hamburger icon when a
page doesn't have a #sidenav.  This worked when sidenav-incl was
being loaded with jQuery load(), because that mechanism works
asynchronously, and #sidenav was part of the DOM before it ran.
Once we started merging HTML fragments directly into the pages, the
script got called before #sidenav was defined, so the icon was
always being removed.

One solution would be to move the script to footer-incl.html, to
follow the preferred practice of placing scripts at the bottom of
the <body>.  The better solution was to move the "no-sidenav" class
from #main to <body>, so that all components can see it.  This lets
us use CSS rules to hide the icon.
This commit is contained in:
Andy McFadden
2021-06-08 13:56:29 -07:00
parent 537668883c
commit 7c5a0dfdb8
20 changed files with 11 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
docs/sgtutorial/visualizations.html
View File

@@ -34,11 +34,6 @@
</a>
</nav>
<script>
// If page has no sidenav, don't show the sidenav toggle button.
if (document.getElementById("sidenav") == undefined) {
$("#topnav-menuicon").hide();
}
// Sidenav toggle function.
//
// Use a jQuery function to toggle the sidenav bar. The initial state