Rename project/platform symbols that clash with opcode mnemonics

We're doing this for user labels but not for project/platform
symbols.  So if you have a constant named "BCC" you can't assemble
your code with certain assemblers.  Now we rename it automatically.

Added a quick test to 2007-labels-and-symbols.  (No change to ACME,
which barfs on the test.)

SourceGen/AsmGen/GenCommon.cs

@@ -159,7 +159,8 @@ namespace SourceGen.AsmGen {
                 string valueStr = PseudoOp.FormatNumericOperand(formatter, proj.SymbolTable,
                     gen.Localizer.LabelMap, defSym.DataDescriptor, defSym.Value, 1,
                     PseudoOp.FormatNumericOpFlags.OmitLabelPrefixSuffix);
-                gen.OutputEquDirective(defSym.Label, valueStr, defSym.Comment);
+                string labelStr = gen.Localizer.ConvLabel(defSym.Label);
+                gen.OutputEquDirective(labelStr, valueStr, defSym.Comment);
 
                 prevConst = defSym.IsConstant;
             }

SourceGen/AsmGen/LabelLocalizer.cs

@@ -293,6 +293,17 @@ namespace SourceGen.AsmGen {
                 allGlobalLabels.Add(newLabel, newLabel);
             }
 
+            // Remap any project/platform symbols that clash with opcode mnemonics.
+            foreach (DefSymbol defSym in mProject.ActiveDefSymbolList) {
+                if (opNames != null && opNames.ContainsKey(defSym.Label.ToUpperInvariant())) {
+                    // Clashed with mnemonic.  Uniquify it.
+                    Debug.WriteLine("Renaming clashing def sym: " + defSym.Label);
+                    string newLabel = MakeUnique(defSym.Label, allGlobalLabels);
+                    LabelMap[defSym.Label] = newLabel;
+                    allGlobalLabels.Add(newLabel, newLabel);
+                }
+            }
+
             //
             // Step 4: remap local labels.  There are two operations here.
             //

SourceGen/SGTestData/Expected/2007-labels-and-symbols_64tass.S

@@ -3,6 +3,7 @@
         .cpu    "65816"
         .enc    sg_ascii
         .cdef   $20,$7e,$20
+BMI1    =       $30        ;opcode mnemonic
 zip     =       $cd
 absl    =       $1029
 absh    =       $feed
@@ -201,7 +202,7 @@ _string .text   "This is a long string. Put a label and comment on it to confir"
 _L118E  lda     #<thirty2+2
         lda     #(>thirty2)+3
         lda     #`thirty2
-        rep     #$30
+        rep     #BMI1
         .al
         .xl
         lda     #(thirty2 & $ffff)+3

SourceGen/SGTestData/Expected/2007-labels-and-symbols_Merlin32.S

@@ -1,5 +1,6 @@
 ;Project was edited to add a label in the middle of a dense hex region, and add
 ;a duplicate label.
+BMI      equ   $30        ;opcode mnemonic
 zip      equ   $cd
 absl     equ   $1029
 absh     equ   $feed
@@ -191,7 +192,7 @@ start    clc
 :L118E   lda   #<thirty2+2
          lda   #>thirty2+$300
          lda   #^thirty2
-         rep   #$30
+         rep   #BMI
          mx    %00
          lda   #thirty2+3
          lda   #>thirty2+$400

SourceGen/SGTestData/Expected/2007-labels-and-symbols_cc65.S

@@ -1,6 +1,7 @@
 ;Project was edited to add a label in the middle of a dense hex region, and add
 ;a duplicate label.
          .setcpu "65816"
+BMI1     =       $30        ;opcode mnemonic
 zip      =       $cd
 absl     =       $1029
 absh     =       $feed
@@ -201,7 +202,7 @@ start:   clc
 @L118E:  lda     #<thirty2+2
          lda     #>thirty2+3
          lda     #^thirty2
-         rep     #$30
+         rep     #BMI1
          .a16
          .i16
          lda     #thirty2 & $ffff +3