6502/CLK
1
0
Fork 0
mirror of https://github.com/TomHarte/CLK.git synced 2024-12-11 15:49:38 +00:00
Code Issues Projects Releases Wiki Activity

Avoid potential extending run-out-of-bounds.

Browse Source
This commit is contained in:
Thomas Harte 2024-12-03 09:18:05 -05:00
parent 9fa71231c4
commit 0371b0507a
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Storage/Tape/Formats/ZXSpectrumTAP.cpp
View File

@ -19,19 +19,20 @@ using namespace Storage::Tape;
*/ */
ZXSpectrumTAP::ZXSpectrumTAP(const std::string &file_name) : ZXSpectrumTAP::ZXSpectrumTAP(const std::string &file_name) :
file_(file_name) file_(file_name, FileHolder::FileMode::Read)
{ {
// Check for a continuous series of blocks through to // Check for a continuous series of blocks through to
// exactly file end. // exactly file end.
// //
// To consider: could also check those blocks of type 0 // To consider: could also check those blocks of type 0
// and type ff for valid checksums? // and type ff for valid checksums?
while(true) { while(file_.tell() != file_.stats().st_size) {
const uint16_t block_length = file_.get16le(); const uint16_t block_length = file_.get16le();
if(file_.eof()) throw ErrorNotZXSpectrumTAP; if(file_.eof() || file_.tell() + block_length >= file_.stats().st_size) {
throw ErrorNotZXSpectrumTAP;
}
file_.seek(block_length, SEEK_CUR); file_.seek(block_length, SEEK_CUR);
if(file_.tell() == file_.stats().st_size) break;
} }
virtual_reset(); virtual_reset();