6502/CLK
1
0
Fork 0
mirror of https://github.com/TomHarte/CLK.git synced 2025-02-27 15:29:34 +00:00
Code Issues Projects Releases Wiki Activity

Remove TODO, add exposition.

Browse Source
This commit is contained in:
Thomas Harte 2023-10-25 16:15:08 -04:00
parent a2826cdee5
commit 29a921f764
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
InstructionSets/x86/Implementation/PerformImplementation.hpp
View File

@ -1815,16 +1815,11 @@ template <
MemoryT &memory, MemoryT &memory,
IOT &io IOT &io
) { ) {
// Dispatch to a function just like this that is specialised on data size.
// Fetching will occur in that specialised function, per the overlapping
// meaning of register names.
// TODO: incorporate and propagate address size.
auto size = [](DataSize operation_size, AddressSize address_size) constexpr -> int { auto size = [](DataSize operation_size, AddressSize address_size) constexpr -> int {
return int(operation_size) + (int(address_size) << 2); return int(operation_size) + (int(address_size) << 2);
}; };
// Dispatch to a function specialised on data and address size.
switch(size(instruction.operation_size(), instruction.address_size())) { switch(size(instruction.operation_size(), instruction.address_size())) {
// 16-bit combinations. // 16-bit combinations.
case size(DataSize::Byte, AddressSize::b16): case size(DataSize::Byte, AddressSize::b16):
@ -1835,6 +1830,10 @@ template <
return; return;
// 32-bit combinations. // 32-bit combinations.
//
// The if constexprs below ensure that `perform` isn't compiled for incompatible data or address size and
// model combinations. So if a caller nominates a 16-bit model it can supply registers and memory objects
// that don't implement 32-bit registers or accesses.
case size(DataSize::Byte, AddressSize::b32): case size(DataSize::Byte, AddressSize::b32):
if constexpr (is_32bit(model)) { if constexpr (is_32bit(model)) {
perform<model, DataSize::Byte, AddressSize::b32>(instruction, status, flow_controller, registers, memory, io); perform<model, DataSize::Byte, AddressSize::b32>(instruction, status, flow_controller, registers, memory, io);
@ -1863,8 +1862,8 @@ template <
default: break; default: break;
} }
// This is reachable only if the data and address size combination in use isn't available on the processor // This is reachable only if the data and address size combination in use isn't available
// model nominated. // on the processor model nominated.
assert(false); assert(false);
} }