From 3ffca200012a629ecbdf4c549033c2e5f913853e Mon Sep 17 00:00:00 2001 From: Thomas Harte Date: Tue, 19 Apr 2022 07:15:54 -0400 Subject: [PATCH] Uncover various discrepancies with NBCD. --- .../Mac/Clock SignalTests/m68kDecoderTests.mm | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/OSBindings/Mac/Clock SignalTests/m68kDecoderTests.mm b/OSBindings/Mac/Clock SignalTests/m68kDecoderTests.mm index b1d9248a8..54b05e4d2 100644 --- a/OSBindings/Mac/Clock SignalTests/m68kDecoderTests.mm +++ b/OSBindings/Mac/Clock SignalTests/m68kDecoderTests.mm @@ -62,16 +62,13 @@ template NSString *operand(Preinstruction instruction) { const auto found = decoder.decode(uint16_t(instr)); - // Hatch off no-instruction as a special case, - // at least temporarily. - if(found.operation == Operation::Undefined) { - XCTAssertEqualObjects(@"None", expected, "%@ should decode as %@", instrName, expected); - continue; - } - NSString *instruction; switch(found.operation) { - case Operation::ABCD: instruction = @"ABCD"; break; + case Operation::Undefined: instruction = @"None"; break; + case Operation::NOP: instruction = @"NOP"; break; + case Operation::ABCD: instruction = @"ABCD"; break; + case Operation::SBCD: instruction = @"SBCD"; break; + case Operation::NBCD: instruction = @"NBCD"; break; // For now, skip any unmapped operations. default: continue;