From 4bc3a3b18945809166cf5df0cee87756211b8e87 Mon Sep 17 00:00:00 2001 From: Thomas Harte Date: Sat, 7 Feb 2026 21:59:24 -0500 Subject: [PATCH] Eliminate colour hack. --- Machines/Apple/AppleII/Video.hpp | 12 +----------- .../xcschemes/Clock Signal Kiosk.xcscheme | 8 ++++---- 2 files changed, 5 insertions(+), 15 deletions(-) diff --git a/Machines/Apple/AppleII/Video.hpp b/Machines/Apple/AppleII/Video.hpp index 7b8e5ac4e..c52f29a1b 100644 --- a/Machines/Apple/AppleII/Video.hpp +++ b/Machines/Apple/AppleII/Video.hpp @@ -471,17 +471,7 @@ private: const int colour_burst_start = std::max(first_sync_column + sync_length + 1, column_); const int colour_burst_end = std::min(first_sync_column + sync_length + 4, ending_column); if(colour_burst_end > colour_burst_start) { - // UGLY HACK AHOY! - // The OpenGL scan target introduces a phase error of 1/8th of a wave. The Metal one does not. - // Supply the real phase value if this is an Apple build. - // TODO: eliminate UGLY HACK. -#if defined(__APPLE__) && !defined(IGNORE_APPLE) - static constexpr uint8_t phase = 224; -#else - static constexpr uint8_t phase = 192; -#endif - - crt_.output_colour_burst((colour_burst_end - colour_burst_start) * 14, phase); + crt_.output_colour_burst((colour_burst_end - colour_burst_start) * 14, 224); } second_blank_start = std::max(first_sync_column + sync_length + 3, column_); diff --git a/OSBindings/Mac/Clock Signal.xcodeproj/xcshareddata/xcschemes/Clock Signal Kiosk.xcscheme b/OSBindings/Mac/Clock Signal.xcodeproj/xcshareddata/xcschemes/Clock Signal Kiosk.xcscheme index 75fe9073f..2a664af9a 100644 --- a/OSBindings/Mac/Clock Signal.xcodeproj/xcshareddata/xcschemes/Clock Signal Kiosk.xcscheme +++ b/OSBindings/Mac/Clock Signal.xcodeproj/xcshareddata/xcschemes/Clock Signal Kiosk.xcscheme @@ -74,11 +74,11 @@ + isEnabled = "YES"> + isEnabled = "NO"> + isEnabled = "NO">