6502/CLK
1
0
Fork 0
mirror of https://github.com/TomHarte/CLK.git synced 2025-01-13 22:32:03 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #309 from TomHarte/ROMSafety

Browse Source 
Ensures all vectors loaded from disk are the expected size.
This commit is contained in:
Thomas Harte 2017-11-25 05:17:23 -08:00 committed by GitHub
commit 573a9c6fb2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 28 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Machines/AmstradCPC/AmstradCPC.cpp
View File

@ -931,7 +931,8 @@ class ConcreteMachine:
// See header; provides the system ROMs. // See header; provides the system ROMs.
void set_rom(ROMType type, const std::vector<uint8_t> &data) { void set_rom(ROMType type, const std::vector<uint8_t> &data) {
roms_[static_cast<int>(type)] = data; roms_[static_cast<int>(type)] = std::move(data);
roms_[static_cast<int>(type)].resize(16384);
} }
// Obtains the system ROMs. // Obtains the system ROMs.

8
Machines/Commodore/Vic-20/Vic20.cpp
View File

@ -335,8 +335,14 @@ class ConcreteMachine:
for(std::size_t index = 0; index < roms.size(); ++index) { for(std::size_t index = 0; index < roms.size(); ++index) {
auto &data = roms[index]; auto &data = roms[index];
if(!data) return false; if(!data) return false;
if(index < 9) roms_[index] = *data; else basic_rom_ = *data; if(index < 9) roms_[index] = std::move(*data); else basic_rom_ = std::move(*data);
} }
// Characters ROMs should be 4kb.
for(std::size_t index = 0; index < 4; ++index) roms_[index].resize(4096);
// Kernel ROMs and the BASIC ROM should be 8kb.
for(std::size_t index = 4; index < roms.size(); ++index) roms_[index].resize(8192);
return true; return true;
} }

28
Machines/Oric/Oric.cpp
View File

@ -204,18 +204,6 @@ class ConcreteMachine:
Memory::Fuzz(ram_, sizeof(ram_)); Memory::Fuzz(ram_, sizeof(ram_));
} }
void set_rom(ROM rom, const std::vector<uint8_t> &data) {
switch(rom) {
case BASIC11: basic11_rom_ = std::move(data); break;
case BASIC10: basic10_rom_ = std::move(data); break;
case Microdisc: microdisc_rom_ = std::move(data); break;
case Colour:
colour_rom_ = std::move(data);
if(video_output_) video_output_->set_colour_rom(colour_rom_);
break;
}
}
// Obtains the system ROMs. // Obtains the system ROMs.
bool set_rom_fetcher(const std::function<std::vector<std::unique_ptr<std::vector<uint8_t>>>(const std::string &machine, const std::vector<std::string> &names)> &roms_with_names) override { bool set_rom_fetcher(const std::function<std::vector<std::unique_ptr<std::vector<uint8_t>>>(const std::string &machine, const std::vector<std::string> &names)> &roms_with_names) override {
auto roms = roms_with_names( auto roms = roms_with_names(
@ -226,11 +214,21 @@ class ConcreteMachine:
}); });
for(std::size_t index = 0; index < roms.size(); ++index) { for(std::size_t index = 0; index < roms.size(); ++index) {
auto &data = roms[index]; if(!roms[index]) return false;
if(!data) return false;
set_rom(static_cast<ROM>(index), *data);
} }
basic10_rom_ = std::move(*roms[0]);
basic11_rom_ = std::move(*roms[1]);
microdisc_rom_ = std::move(*roms[2]);
colour_rom_ = std::move(*roms[3]);
basic10_rom_.resize(16384);
basic11_rom_.resize(16384);
microdisc_rom_.resize(8192);
colour_rom_.resize(128);
if(video_output_) video_output_->set_colour_rom(colour_rom_);
return true; return true;
} }

16
Machines/ZX8081/ZX8081.cpp
View File

@ -297,13 +297,6 @@ template<bool is_zx81> class ConcreteMachine:
Utility::TypeRecipient::set_typer_for_string(string, std::move(mapper)); Utility::TypeRecipient::set_typer_for_string(string, std::move(mapper));
} }
void set_rom(ROMType type, const std::vector<uint8_t> &data) {
switch(type) {
case ZX80: zx80_rom_ = data; break;
case ZX81: zx81_rom_ = data; break;
}
}
// Obtains the system ROMs. // Obtains the system ROMs.
bool set_rom_fetcher(const std::function<std::vector<std::unique_ptr<std::vector<uint8_t>>>(const std::string &machine, const std::vector<std::string> &names)> &roms_with_names) override { bool set_rom_fetcher(const std::function<std::vector<std::unique_ptr<std::vector<uint8_t>>>(const std::string &machine, const std::vector<std::string> &names)> &roms_with_names) override {
auto roms = roms_with_names( auto roms = roms_with_names(
@ -313,11 +306,14 @@ template<bool is_zx81> class ConcreteMachine:
}); });
for(std::size_t index = 0; index < roms.size(); ++index) { for(std::size_t index = 0; index < roms.size(); ++index) {
auto &data = roms[index]; if(!roms[index]) return false;
if(!data) return false;
set_rom(static_cast<ROMType>(index), *data);
} }
zx80_rom_ = std::move(*roms[0]);
zx81_rom_ = std::move(*roms[1]);
zx80_rom_.resize(4096);
zx81_rom_.resize(8192);
return true; return true;
} }