From 73d2acca12643292e922f192bea22425c2cb6264 Mon Sep 17 00:00:00 2001 From: Thomas Harte Date: Thu, 22 Feb 2024 11:20:22 -0500 Subject: [PATCH] Moderately improve comments. --- InstructionSets/ARM/OperationMapper.hpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/InstructionSets/ARM/OperationMapper.hpp b/InstructionSets/ARM/OperationMapper.hpp index 025572d6a..83c04a12a 100644 --- a/InstructionSets/ARM/OperationMapper.hpp +++ b/InstructionSets/ARM/OperationMapper.hpp @@ -80,6 +80,9 @@ constexpr bool flag_bit(uint8_t flags) { return flags & (1 << (position - FlagsStartBit)); } +// +// Methods common to data processing and data transfer. +// struct WithShiftControlBits { constexpr WithShiftControlBits(uint32_t opcode) noexcept : opcode_(opcode) {} @@ -121,6 +124,7 @@ struct DataProcessingFlags { /// @c false if it is defined by the @c shift_*() and @c operand2() fields. constexpr bool operand2_is_immediate() { return flag_bit<25>(flags_); } + /// @c true if the status register should be updated; @c false otherwise. constexpr bool set_condition_codes() { return flag_bit<20>(flags_); } private: @@ -152,6 +156,7 @@ struct DataProcessing: public WithShiftControlBits { struct MultiplyFlags { constexpr MultiplyFlags(uint8_t flags) noexcept : flags_(flags) {} + /// @c true if the status register should be updated; @c false otherwise. constexpr bool set_condition_codes() { return flag_bit<20>(flags_); } private: