diff --git a/OSBindings/Mac/Clock Signal/Machine/StaticAnalyser/CSStaticAnalyser.mm b/OSBindings/Mac/Clock Signal/Machine/StaticAnalyser/CSStaticAnalyser.mm index 19987ec94..db98fa18a 100644 --- a/OSBindings/Mac/Clock Signal/Machine/StaticAnalyser/CSStaticAnalyser.mm +++ b/OSBindings/Mac/Clock Signal/Machine/StaticAnalyser/CSStaticAnalyser.mm @@ -42,7 +42,7 @@ struct PermissionDelegate: public Storage::FileBundle::FileBundle::PermissionDel NSString *bookmarkKey = [[url URLByDeletingLastPathComponent] absoluteString]; while(true) { - // If the file can already be read, no further action required. + // If the file exists can already be read, no further action required. // That is, given that the macOS sandbox doesn't differentiate read/write access once permission is granted. NSError *error; NSFileHandle *file = [NSFileHandle fileHandleForReadingFromURL:url error:&error]; @@ -50,6 +50,8 @@ struct PermissionDelegate: public Storage::FileBundle::FileBundle::PermissionDel return; } + // TODO: if that file doesn't exist... try anything? + // Was failure to open due to permissions? if( error.domain != NSCocoaErrorDomain || @@ -79,6 +81,8 @@ struct PermissionDelegate: public Storage::FileBundle::FileBundle::PermissionDel bookmarkDataIsStale:nil error:nil]; [accessURL startAccessingSecurityScopedResource]; + } else { + break; } }