6502/CLK
1
0
Fork 0
mirror of https://github.com/TomHarte/CLK.git synced 2024-11-26 23:52:26 +00:00
Code Issues Projects Releases Wiki Activity

Fix memory mask; mildly improve commentary.

Browse Source
This commit is contained in:
Thomas Harte 2023-02-05 22:51:16 -05:00
parent 7fcb1b29dd
commit f9c88fd598
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Components/9918/Implementation/9918.cpp
View File

@ -604,7 +604,6 @@ int Base<personality>::masked_address(int address) const {
template <Personality personality> template <Personality personality>
void Base<personality>::write_vram(uint8_t value) { void Base<personality>::write_vram(uint8_t value) {
// Latch the value and exit.
write_phase_ = false; write_phase_ = false;
// Enqueue the write to occur at the next available slot. // Enqueue the write to occur at the next available slot.
@ -775,7 +774,7 @@ void Base<personality>::commit_register(int reg, uint8_t value) {
// b4–b7: display time for even page. // b4–b7: display time for even page.
break; break;
case 14: install_field<14>(ram_pointer_, value); break; case 14: install_field<14, 3>(ram_pointer_, value); break;
case 15: case 15:
Storage<personality>::selected_status_ = value & 0xf; Storage<personality>::selected_status_ = value & 0xf;
@ -871,9 +870,9 @@ void Base<personality>::commit_register(int reg, uint8_t value) {
default: break; default: break;
case 0b0100: break; // TODO: point. [read a pixel colour] case 0b0100: break; // TODO: point. [read a pixel colour]
case 0b0101: Begin(PointSet); break; // PSET. case 0b0101: Begin(PointSet); break; // PSET [plot a pixel].
case 0b0110: break; // TODO: srch. [search horizontally for a colour] case 0b0110: break; // TODO: srch. [search horizontally for a colour]
case 0b0111: Begin(Line); break; // LINE. case 0b0111: Begin(Line); break; // LINE [draw a Bresenham line].
case 0b1000: Begin(LogicalFill); break; // LMMV [logical move, VDP to VRAM, i.e. solid-colour fill]. case 0b1000: Begin(LogicalFill); break; // LMMV [logical move, VDP to VRAM, i.e. solid-colour fill].
case 0b1001: Begin(LogicalMove); break; // LMMM [logical move, VRAM to VRAM]. case 0b1001: Begin(LogicalMove); break; // LMMM [logical move, VRAM to VRAM].

4
Components/9918/Implementation/PersonalityTraits.hpp
View File

@ -42,8 +42,8 @@ constexpr size_t memory_size(Personality p) {
} }
} }
constexpr uint16_t memory_mask(Personality p) { constexpr size_t memory_mask(Personality p) {
return (memory_size(p) >= 65536) ? 0xffff : uint16_t(memory_size(p) - 1); return memory_size(p) - 1;
} }
} }