// // 68000ComparativeTests.cpp // Clock SignalTests // // Created by Thomas Harte on 14/12/2019. // Copyright © 2019 Thomas Harte. All rights reserved. // #import #include "../../../Processors/68000/68000.hpp" #include "../../../InstructionSets/M68k/Executor.hpp" #include "../../../InstructionSets/M68k/Decoder.hpp" #include #include #include //#define USE_EXECUTOR //#define MAKE_SUGGESTIONS //#define LOG_UNTESTED namespace { /// Binds a 68000 executor to 16mb of RAM. struct TestExecutor { uint8_t *const ram; InstructionSet::M68k::Executor processor; TestExecutor(uint8_t *ram) : ram(ram), processor(*this) {} void run_for_instructions(int instructions) { processor.run_for_instructions(instructions); } // Initial test-case implementation: // do a very sedate read and write. template IntT read(uint32_t address, InstructionSet::M68k::FunctionCode) { if constexpr (sizeof(IntT) == 1) { return IntT(ram[address & 0xffffff]); } if constexpr (sizeof(IntT) == 2) { return IntT( (ram[address & 0xffffff] << 8) | ram[(address+1) & 0xffffff] ); } if constexpr (sizeof(IntT) == 4) { return IntT( (ram[address & 0xffffff] << 24) | (ram[(address+1) & 0xffffff] << 16) | (ram[(address+2) & 0xffffff] << 8) | ram[(address+3) & 0xffffff] ); } return 0; } template void write(uint32_t address, IntT value, InstructionSet::M68k::FunctionCode) { if constexpr (sizeof(IntT) == 1) { ram[address & 0xffffff] = uint8_t(value); } if constexpr (sizeof(IntT) == 2) { ram[address & 0xffffff] = uint8_t(value >> 8); ram[(address+1) & 0xffffff] = uint8_t(value); } if constexpr (sizeof(IntT) == 4) { ram[address & 0xffffff] = uint8_t(value >> 24); ram[(address+1) & 0xffffff] = uint8_t(value >> 16); ram[(address+2) & 0xffffff] = uint8_t(value >> 8); ram[(address+3) & 0xffffff] = uint8_t(value); } } void reset() {} int acknowlege_interrupt(int) { return -1; } }; /// Binds a bus-accurate 68000 to 16mb of RAM. struct TestProcessor: public CPU::MC68000::BusHandler { uint8_t *const ram; CPU::MC68000::Processor processor; std::function comparitor; TestProcessor(uint8_t *ram) : ram(ram), processor(*this) {} void will_perform(uint32_t, uint16_t) { --instructions_remaining_; if(!instructions_remaining_) comparitor(); } using Microcycle = CPU::MC68000::Microcycle; template HalfCycles perform_bus_operation(const Microcycle &cycle, int) { if(cycle.data_select_active()) { cycle.apply(&ram[cycle.host_endian_byte_address()]); } return HalfCycles(0); } void run_for_instructions(int instructions, const std::function &compare) { instructions_remaining_ = instructions + 1; // i.e. run up to the will_perform of the instruction after. comparitor = std::move(compare); while(instructions_remaining_) { processor.run_for(HalfCycles(2)); } } private: int instructions_remaining_; }; } @interface M68000ComparativeTests : XCTestCase @end @implementation M68000ComparativeTests { NSSet *_fileSet; NSSet *_testSet; NSMutableSet *_failures; NSMutableArray *_failingOpcodes; NSMutableDictionary *> *_suggestedCorrections; NSMutableSet *_testedOpcodes; InstructionSet::M68k::Predecoder _decoder; std::array _ram; std::unique_ptr _testExecutor; } - (void)setUp { // Definitively erase any prior memory contents; // 0xce is arbitrary but hopefully easier to spot // in potential errors than e.g. 0x00 or 0xff. _ram.fill(0xcece); // TODO: possibly, worry about resetting RAM to 0xce after tests have completed. #ifdef USE_EXECUTOR _testExecutor = std::make_unique(reinterpret_cast(_ram.data())); #endif // These will accumulate a list of failing tests and associated opcodes. _failures = [[NSMutableSet alloc] init]; _failingOpcodes = [[NSMutableArray alloc] init]; // This will simply accumulate a list of all tested opcodes, in order to report // on those that are missing. _testedOpcodes = [[NSMutableSet alloc] init]; #ifdef MAKE_SUGGESTIONS _suggestedCorrections = [[NSMutableDictionary alloc] init]; #endif // To limit tests run to a subset of files and/or of tests, uncomment and fill in below. // _fileSet = [NSSet setWithArray:@[@"abcd_sbcd.json"]]; // _testSet = [NSSet setWithArray:@[@"LINK.w 0007"]]; } - (void)testAll { // Get the full list of available test files. NSBundle *const bundle = [NSBundle bundleForClass:[self class]]; NSArray *const tests = [bundle URLsForResourcesWithExtension:@"json" subdirectory:@"68000 Comparative Tests"]; // Issue each test file. for(NSURL *url in tests) { // Compare against a file set if one has been supplied. if(_fileSet && ![_fileSet containsObject:[url lastPathComponent]]) continue; // NSLog(@"Testing %@", url); [self testJSONAtURL:url]; } XCTAssert(_failures.count == 0); // Output a summary of failures, if any. if(_failures.count) { NSLog(@"Total failures: %@", @(_failures.count)); NSLog(@"Failures: %@", _failures); NSLog(@"Failing opcodes:"); for(NSNumber *number in _failingOpcodes) { const auto decoded = _decoder.decode(number.intValue); const std::string description = decoded.to_string(number.intValue); NSLog(@"%04x %s", number.intValue, description.c_str()); for(NSString *suggestion in _suggestedCorrections[number]) { NSLog(@"%@", suggestion); } } } #ifdef LOG_UNTESTED // Output a list of untested opcodes. NSMutableArray *untested = [[NSMutableArray alloc] init]; for(int opcode = 0; opcode < 65536; opcode++) { const auto instruction = _decoder.decode(uint16_t(opcode)); if(instruction.operation == InstructionSet::M68k::Operation::Undefined) { continue; } if([_testedOpcodes containsObject:@(opcode)]) { continue; } [untested addObject:[NSString stringWithFormat:@"%04x %s", opcode, instruction.to_string(uint16_t(opcode)).c_str()]]; } NSLog(@"Untested: %@", untested); #endif } - (void)testJSONAtURL:(NSURL *)url { // Read the nominated file and parse it as JSON. NSData *const data = [NSData dataWithContentsOfURL:url]; NSError *error; NSArray *const jsonContents = [NSJSONSerialization JSONObjectWithData:data options:0 error:&error]; XCTAssertNil(error); XCTAssertNotNil(jsonContents); XCTAssert([jsonContents isKindOfClass:[NSArray class]]); // Perform each dictionary in the array as a test. for(NSDictionary *test in jsonContents) { if(![test isKindOfClass:[NSDictionary class]]) continue; // Only entries with a name are valid. NSString *const name = test[@"name"]; if(!name) continue; // Compare against a test set if one has been supplied. if(_testSet && ![_testSet containsObject:name]) continue; // Pull out the opcode and record it. NSArray *const initialMemory = test[@"initial memory"]; uint16_t opcode = 0; NSEnumerator *enumerator = [initialMemory objectEnumerator]; while(true) { NSNumber *const address = [enumerator nextObject]; NSNumber *const value = [enumerator nextObject]; if(!address || !value) break; if(address.integerValue == 0x100) opcode |= value.integerValue << 8; if(address.integerValue == 0x101) opcode |= value.integerValue; } [_testedOpcodes addObject:@(opcode)]; #ifdef USE_EXECUTOR [self testOperationExecutor:test name:name]; #else [self testOperationClassic:test name:name]; #endif } } - (void)testOperationClassic:(NSDictionary *)test name:(NSString *)name { struct TerminateMarker {}; auto uniqueTest68000 = std::make_unique(reinterpret_cast(_ram.data())); auto test68000 = uniqueTest68000.get(); { // Apply initial memory state. NSArray *const initialMemory = test[@"initial memory"]; NSEnumerator *enumerator = [initialMemory objectEnumerator]; while(true) { NSNumber *const address = [enumerator nextObject]; NSNumber *const value = [enumerator nextObject]; if(!address || !value) break; test68000->ram[address.integerValue ^ 1] = value.integerValue; // Effect a short-resolution endianness swap. } // Apply initial processor state. auto state = test68000->processor.get_state(); state.registers = [self initialRegisters:test]; test68000->processor.set_state(state); } // Check that this is a defined opcode; capture of the unrecognised instruction // exception doesn't work correctly with the way that this test class tries // to detect the gaps between operations. const uint16_t opcode = (test68000->ram[0x101] << 8) | test68000->ram[0x100]; if(_decoder.decode(opcode).operation == InstructionSet::M68k::Operation::Undefined) { return; } // Run the thing. const auto comparitor = [=] { const auto state = test68000->processor.get_state(); [self test:test name:name compareFinalRegisters:state.registers opcode:opcode pcOffset:-4]; // Test final memory state. NSArray *const finalMemory = test[@"final memory"]; NSEnumerator *enumerator = [finalMemory objectEnumerator]; while(true) { NSNumber *const address = [enumerator nextObject]; NSNumber *const value = [enumerator nextObject]; if(!address || !value) break; XCTAssertEqual(test68000->ram[address.integerValue ^ 1], value.integerValue, @"%@: Memory at location %@ inconsistent", name, address); if(test68000->ram[address.integerValue ^ 1] != value.integerValue) [_failures addObject:name]; } // Consider collating extra detail. if([_failures containsObject:name]) { [_failingOpcodes addObject:@(opcode)]; } // Make sure nothing further occurs; keep this test isolated. throw TerminateMarker(); }; try { test68000->run_for_instructions(1, comparitor); } catch(TerminateMarker m) {} } - (void)setInitialState:(NSDictionary *)test { // Apply initial memory state. NSArray *const initialMemory = test[@"initial memory"]; NSEnumerator *enumerator = [initialMemory objectEnumerator]; while(true) { NSNumber *const address = [enumerator nextObject]; NSNumber *const value = [enumerator nextObject]; if(!address || !value) break; _testExecutor->ram[address.integerValue] = value.integerValue; } // Apply initial processor state. _testExecutor->processor.set_state([self initialRegisters:test]); } - (void)testOperationExecutor:(NSDictionary *)test name:(NSString *)name { [self setInitialState:test]; // Run the thing. _testExecutor->run_for_instructions(1); // Test the end state. const auto state = _testExecutor->processor.get_state(); const uint16_t opcode = _testExecutor->read(0x100, InstructionSet::M68k::FunctionCode()); [self test:test name:name compareFinalRegisters:state opcode:opcode pcOffset:0]; // Test final memory state. NSArray *const finalMemory = test[@"final memory"]; NSEnumerator *enumerator = [finalMemory objectEnumerator]; while(true) { NSNumber *const address = [enumerator nextObject]; NSNumber *const value = [enumerator nextObject]; if(!address || !value) break; if(_testExecutor->ram[address.integerValue] != value.integerValue) [_failures addObject:name]; } // If this test is now in the failures set, add the corresponding opcode for // later logging. if([_failures containsObject:name]) { // Add this opcode to the failing list. [_failingOpcodes addObject:@(opcode)]; // Generate the JSON that would have satisfied this test, at least as far as registers go, // if those are being collected. if(_suggestedCorrections) { NSMutableDictionary *generatedTest = [test mutableCopy]; NSMutableDictionary *generatedState = generatedTest[@"final state"] = [test[@"final state"] mutableCopy]; for(int c = 0; c < 8; ++c) { const NSString *dX = [@"d" stringByAppendingFormat:@"%d", c]; const NSString *aX = [@"a" stringByAppendingFormat:@"%d", c]; generatedState[dX] = @(state.data[c]); if(c < 7) generatedState[aX] = @(state.address[c]); } generatedState[@"a7"] = @(state.supervisor_stack_pointer); generatedState[@"usp"] = @(state.user_stack_pointer); generatedState[@"sr"] = @(state.status); NSString *const generatedJSON = [[NSString alloc] initWithData: [NSJSONSerialization dataWithJSONObject:generatedTest options:0 error:nil] encoding:NSUTF8StringEncoding]; if(_suggestedCorrections[@(opcode)]) { [_suggestedCorrections[@(opcode)] addObject:generatedJSON]; } else { _suggestedCorrections[@(opcode)] = [NSMutableArray arrayWithObject:generatedJSON]; } } } } - (InstructionSet::M68k::RegisterSet)initialRegisters:(NSDictionary *)test { InstructionSet::M68k::RegisterSet registers; NSDictionary *const initialState = test[@"initial state"]; for(int c = 0; c < 8; ++c) { const NSString *dX = [@"d" stringByAppendingFormat:@"%d", c]; const NSString *aX = [@"a" stringByAppendingFormat:@"%d", c]; registers.data[c] = uint32_t([initialState[dX] integerValue]); if(c < 7) registers.address[c] = uint32_t([initialState[aX] integerValue]); } registers.supervisor_stack_pointer = uint32_t([initialState[@"a7"] integerValue]); registers.user_stack_pointer = uint32_t([initialState[@"usp"] integerValue]); registers.status = [initialState[@"sr"] integerValue]; registers.program_counter = uint32_t([initialState[@"pc"] integerValue]); return registers; } - (void)test:(NSDictionary *)test name:(NSString *)name compareFinalRegisters:(InstructionSet::M68k::RegisterSet)registers opcode:(uint16_t)opcode pcOffset:(int)pcOffset { // Test the end state. NSDictionary *const finalState = test[@"final state"]; for(int c = 0; c < 8; ++c) { const NSString *dX = [@"d" stringByAppendingFormat:@"%d", c]; const NSString *aX = [@"a" stringByAppendingFormat:@"%d", c]; if(registers.data[c] != [finalState[dX] integerValue]) [_failures addObject:name]; if(c < 7 && registers.address[c] != [finalState[aX] integerValue]) [_failures addObject:name]; } if(registers.supervisor_stack_pointer != [finalState[@"a7"] integerValue]) [_failures addObject:name]; if(registers.user_stack_pointer != [finalState[@"usp"] integerValue]) [_failures addObject:name]; if(registers.program_counter + pcOffset != [finalState[@"pc"] integerValue]) [_failures addObject:name]; const uint16_t correctSR = [finalState[@"sr"] integerValue]; if(registers.status != correctSR) { const auto instruction = _decoder.decode(opcode); // For DIVU and DIVS, for now, test only the well-defined flags. if( instruction.operation != InstructionSet::M68k::Operation::DIVSw && instruction.operation != InstructionSet::M68k::Operation::DIVUw ) { [_failures addObject:name]; } else { uint16_t status_mask = 0xff13; // i.e. extend, which should be unaffected, and overflow, which // is well-defined unless there was a divide by zero. But this // test set doesn't include any divide by zeroes. if(!(correctSR & InstructionSet::M68k::ConditionCode::Overflow)) { // If overflow didn't occur then negative and zero are also well-defined. status_mask |= 0x000c; } if((registers.status & status_mask) != (([finalState[@"sr"] integerValue]) & status_mask)) { [_failures addObject:name]; } } } } @end